Moving files from MePo theme Titan skin with FanartHandler support #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewjswan
changed the base branch from
MP1.34_Pre.Release_Test3
to
MP1.34_Pre.Release_Test5
andrewjswan
reviewed
May 14, 2024
| <posY>266</posY> | ||
| <width>48</width> | ||
| <height>48</height> | ||
| <texture>lock.png</texture> |
There was a problem hiding this comment.
Why did we remove this picture?
There was a problem hiding this comment.
This was copied from MovingPictures and looks better.
andrewjswan
reviewed
May 14, 2024
| @@ -6,7 +6,6 @@ | |||
| <define>#header.label:604</define> | |||
| <controls> | |||
|
|
|||
| <import>common.default.background.xml</import> | |||
There was a problem hiding this comment.
Don't we need background here?
There was a problem hiding this comment.
Probably, I just copied this over from MePo but did not check it. I personally have not made any changes to this as I don't use the plugin.
andrewjswan
merged commit 7283f43
into
MediaPortal:MP1.34_Pre.Release_Test5
6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving files from MePo theme Titan skin with FanartHandler support