Implement more options, for p11kcv
#60
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EditUndo
reviewed
Apr 23, 2024
| @@ -223,6 +223,7 @@ typedef enum { | |||
| sha512 | |||
| } hash_alg_t ; | |||
|
|
|||
|
|
|||
EditUndo
reviewed
Apr 23, 2024
| @@ -31,9 +32,10 @@ | |||
| #define LABEL_WIDTH 32 | |||
| #endif | |||
|
|
|||
|
|
|||
EditUndo
reviewed
Apr 23, 2024
| @@ -90,6 +92,9 @@ void pkcs11_display_kcv( pkcs11Context *p11Context, char *label, unsigned hmacda | |||
| _ATTR(CKA_KEY_TYPE), | |||
| _ATTR(CKA_ID), | |||
| _ATTR(CKA_LABEL), | |||
| _ATTR(CKA_CHECK_VALUE), | |||
EditUndo
reviewed
Apr 23, 2024
| @@ -31,9 +32,10 @@ | |||
| #define LABEL_WIDTH 32 | |||
| #endif | |||
|
|
|||
|
|
|||
EditUndo
reviewed
Apr 23, 2024
| /* target must point to a location with at least 3 bytes left */ | ||
|
|
||
| void pkcs11_display_kcv( pkcs11Context *p11Context, char *label, unsigned hmacdatasize ) | ||
| void pkcs11_display_kcv( pkcs11Context *p11Context, char *label, unsigned hmacdatasize, mac_alg_t algo, size_t num_bytes) |
There was a problem hiding this comment.
This function is too big. Consider chunking it down into smaller support functions and doing away with the nested switch statements.
EditUndo
reviewed
Apr 23, 2024
Comment on lines
107
to
124
| CK_MECHANISM des_ecb = { CKM_DES_ECB, NULL_PTR, 0 }; | ||
| CK_MECHANISM des_mac = { CKM_DES_MAC, NULL_PTR, 0 }; | ||
|
|
||
| CK_MECHANISM des3_ecb = { CKM_DES3_ECB, NULL_PTR, 0 }; | ||
| CK_MECHANISM des3_mac = { CKM_DES3_MAC, NULL_PTR, 0 }; | ||
| CK_MECHANISM des3_cmac = { CKM_DES3_CMAC, NULL_PTR, 0 }; | ||
|
|
||
| CK_MECHANISM aes_ecb = { CKM_AES_ECB, NULL_PTR, 0 }; | ||
| CK_MECHANISM aes_mac = { CKM_AES_MAC, NULL_PTR, 0 }; | ||
| CK_MECHANISM aes_cmac = { CKM_AES_CMAC, NULL_PTR, 0 }; | ||
| CK_MECHANISM m_aes_xcbc_mac = { CKM_AES_XCBC_MAC, NULL_PTR, 0}; | ||
| CK_MECHANISM m_aes_xcbc_mac_96 = { CKM_AES_XCBC_MAC_96, NULL_PTR, 0}; | ||
|
|
||
| CK_MECHANISM sha1_hmac = { CKM_SHA_1_HMAC, NULL_PTR, 0 }; | ||
| CK_MECHANISM sha224_hmac = { CKM_SHA224_HMAC, NULL_PTR, 0 }; | ||
| CK_MECHANISM sha256_hmac = { CKM_SHA256_HMAC, NULL_PTR, 0 }; | ||
| CK_MECHANISM sha384_hmac = { CKM_SHA384_HMAC, NULL_PTR, 0 }; | ||
| CK_MECHANISM sha512_hmac = { CKM_SHA512_HMAC, NULL_PTR, 0 }; |
There was a problem hiding this comment.
Predefining these seems like overkill since only one mechanism will be used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings the following features:
CKA_CHECK_VALUEcan be used (when present)This PR should address the requests from issue #59.