Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Super(Windows) key in shortcuts #3632

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

huhle
Copy link

@huhle huhle commented Sep 25, 2019

Just added Super key to the list of accelerators, so win key can by also used as part of shortcut.
Seems like a nice feature IMO

@welcome
Copy link

welcome bot commented Sep 25, 2019

💖 Thanks for opening this pull request! 💖
Here is a list of things that will help get it across the finish line: - Run npm run lint locally to catch formatting errors earlier. - Include tests when adding/changing behavior. - Include screenshots and animated GIFs whenever possible. - If you added new translation strings ensure that you have added empty strings for all languages - If you added new functionality or modified existing functionality please ensure it is tested

@huhle
Copy link
Author

huhle commented Jan 19, 2020

Hi, I am pretty sure that I didn't break the darwin build. Is there anything I can do with it? Maybe just try it again?

@huhle huhle force-pushed the feature/super-key-support branch from 6c047ed to a995baf Compare March 6, 2020 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant