Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MDEV-34175 mtr_t::log_close() warning should change the shutdown condition #3258

Merged
merged 1 commit into from
May 20, 2024

Conversation

Thirunarayanan
Copy link
Member

  • The Jira issue number for this PR is: MDEV-______

Description

  • InnoDB can print the wrong warning message like "shutdown is in progress" even though InnoDB is in normal
    condition. InnoDB should print the warning message saying "Shutdown is in progress" only when shutdown state is greater than SRV_SHUTDOWN_INITIATED.

Basing the PR against the correct MariaDB version

  • This is a new feature and the PR is based against the latest MariaDB development branch.
  • This is a bug fix and the PR is based against the earliest maintained branch in which the bug can be reproduced.

PR quality check

  • I checked the CODING_STANDARDS.md file and my PR conforms to this where appropriate.
  • For any trivial modifications to the PR, I am ok with the reviewer making the changes themselves.

@Thirunarayanan Thirunarayanan requested a review from dr-m May 15, 2024 13:10
@CLAassistant
Copy link

CLAassistant commented May 15, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
3 out of 10 committers have signed the CLA.

✅ grooverdan
✅ tohghua
✅ dbart
❌ vuvova
❌ dr-m
❌ mariadb-YuchenPei
❌ abarkov
❌ robinnewhouse
❌ DaveGosselin-MariaDB
❌ Thirunarayanan
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Contributor

@dr-m dr-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would seem to be applicable to 10.5 as well.

…ition

- InnoDB should print the warning message saying
"Shutdown is in progress" only when shutdown state
is greater than SRV_SHUTDOWN_INITIATED.
@Thirunarayanan Thirunarayanan changed the base branch from 10.6 to 10.5 May 20, 2024 12:49
@Thirunarayanan Thirunarayanan merged commit ac2e02e into 10.5 May 20, 2024
12 of 18 checks passed
@Thirunarayanan Thirunarayanan deleted the 10.6-MDEV-34175 branch May 20, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants