Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration with Teamcity status message #611

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Vacxe
Copy link
Member

@Vacxe Vacxe commented Feb 25, 2022

No description provided.

@tagantroy
Copy link
Member

Please provide more details about this feature, also we will need to update docs after you merge it.

id("org.jetbrains.dokka")
}

Deployment.initialize(project)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're adding a new module - it should be published as well. I don't think we need to create a separate jar for this though

@@ -73,7 +75,8 @@ data class Configuration private constructor(
"debug" to debug.toString(),
"screenRecordingPolicy" to screenRecordingPolicy.toString(),
"vendorConfiguration" to vendorConfiguration.toString(),
"deviceInitializationTimeoutMillis" to deviceInitializationTimeoutMillis.toString()
"deviceInitializationTimeoutMillis" to deviceInitializationTimeoutMillis.toString(),
"buildSystem" to buildSystem
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This probably should be a separate configuration class, e.g. BuildSystemConfiguration -> TeamCityConfiguration instead of just an enum. Otherwise we don't make it extensible in the future with parameters to the build system (e.g. ignore X, print more, etc)

@Vacxe Vacxe force-pushed the buildsystem-integration-poc branch from aa111b3 to 949f101 Compare April 5, 2022 12:14
@Vacxe Vacxe force-pushed the buildsystem-integration-poc branch from 949f101 to b6ad034 Compare April 5, 2022 12:34
@codecov-commenter
Copy link

codecov-commenter commented Apr 5, 2022

Codecov Report

Merging #611 (b6ad034) into develop (3658eec) will decrease coverage by 2.06%.
The diff coverage is 55.55%.

@@              Coverage Diff              @@
##             develop     #611      +/-   ##
=============================================
- Coverage      64.98%   62.92%   -2.07%     
- Complexity       696      705       +9     
=============================================
  Files            168      174       +6     
  Lines           3336     3517     +181     
  Branches         565      588      +23     
=============================================
+ Hits            2168     2213      +45     
- Misses           881     1008     +127     
- Partials         287      296       +9     
Impacted Files Coverage Δ
...iy/marathon/config/BuildManagementConfiguration.kt 50.00% <50.00%> (ø)
...lin/com/malinskiy/marathon/config/Configuration.kt 47.87% <50.00%> (+0.08%) ⬆️
...y/marathon/integration/buildmanagement/Teamcity.kt 50.00% <50.00%> (ø)
...iy/marathon/execution/progress/ProgressReporter.kt 69.23% <60.00%> (-9.35%) ⬇️
...alinskiy/marathon/config/AnalyticsConfiguration.kt 50.00% <0.00%> (-25.00%) ⬇️
...athon/analytics/external/MetricsProviderFactory.kt 44.82% <0.00%> (-16.72%) ⬇️
...athon/config/vendor/android/AllureConfiguration.kt 100.00% <0.00%> (ø)
...tics/metrics/remote/influx2/InfluxDB2DataSource.kt 0.00% <0.00%> (ø)
...on/analytics/external/influx2/InfluxDb2Provider.kt 0.00% <0.00%> (ø)
...hon/analytics/external/influx2/InfluxDb2Tracker.kt 0.00% <0.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3658eec...b6ad034. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants