WIP Use ImageSource instead of BitmapId everywhere #2628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pauldendulk
commented
May 10, 2024
|
|
||
| private readonly ConcurrentHashSet<int> _createdImages = []; | ||
| private readonly ConcurrentHashSet<string> _createdBitmapPathImages = []; | ||
| private bool _disposed; |
There was a problem hiding this comment.
Now working with two caches here. This is temporary.
| VectorCache = new VectorCache(this, capacity); | ||
| } | ||
|
|
||
| public ISymbolCache SymbolCache { get; } | ||
| public IVectorCache VectorCache { get; } | ||
| public ITileCache TileCache { get; } | ||
| public ILabelCache LabelCache { get; } | ||
| public IBitmapRegistry BitmapRegistry { get; } | ||
| public IRenderBitmapRegistry BitmapRegistry { get; } |
There was a problem hiding this comment.
Splitting things up in this phase.
|
This commit add a BitmapPathInitializer which calls a fire and forget method in the render loop which initializes if needed and and if so calls a callback to allow graphics refrehs. https://github.com/Mapsui/Mapsui/pull/2628/commits In the current solution the bitmapath atlas solution is horribly slow. The should be rewritten to use just urls. |
Rewrite Sprites
Replace BitmapPath with BitmapId
Rename BitmapPath to ImageSource
…ature/bitmapregistry
Replace BitmapInfo with IDrawableImage
Let ImageFetcher return byte arrays
…to feature/rename-symbolcache
Reorganize a few extension method
…o feature/rename-symbolcache
… into feature/rename-symbolcache
Rename SymbolCache to DrawableImageCache
…ource Add ImageButtonWidget.ImageSource
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In previous PRs it was made possible to load image streams through a url. The underlying idea of working with such a url is that this url itself could serve as the key for the cache, not needing a bitmapId. The first implementation of bitmapPath did not work like that yet. BitmapPath's were also assigned a bitmapId. So in the case of bitmapPath's this was an extra layer on top of the bitmapPath. This PR attempts to remove that. I introduced a BitmapPathRegistry that should function like that. Eventually this may replace the BitmapRegistry entirely.
This is just te beginnen of a rewrite of the mechanism to cache bitmapPath. I split off a new BitmapPathRegistry which should only store bitmapPath items. So in todays version we have two mechanisms which does not make this better right away.