Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO NOT MERGE: Feat/test benchmark suite crypto primitives #208

Draft
wants to merge 31 commits into
base: main
Choose a base branch
from

Conversation

SupremoUGH
Copy link
Contributor

@SupremoUGH SupremoUGH commented Aug 19, 2022

DO NOT MERGE: Move to OpenZL.

New:

Testing for cryptographic abstractions in manta-crypto:

  • duplex.rs: Added correctness test for duplex sponge encryption.
  • encryption: Added ciphertext validity test for encryption.
  • algebra.rs: Added several algebraic tests.
  • accumulator.rs: Added proof removal tests for OptimizedAccumulator.
  • hash.rs: Added preimage and collision resistance tests for HashFunction.
  • signature: Added preimage resistance test for HashFunction.
  • constraint.rs: Added correctness test for ProofSystem.

Testing for concrete implementations in manta_pay:

  • encryption: Added invalid key and invalid ciphertext tests for symmetric encryption.
  • poseidon::hash: Added naive collision resistance tests for Poseidon with arities 2 and 4.

Goals:
Cryptographic abstractions:

  • Correctness test.
  • Native performance benchmark.
  • Circuit constraint measurement.

Concrete implementations:

  • Randomized testing suite.
  • Benchmarks.
  • Constraint measurement.

Closes #112

Before we can merge this PR, please make sure that all the following items have been checked off:

  • Linked to an issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Added one line describing your change in CHANGELOG.md and added the appropriate changelog label to the PR.
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Checked that changes and commits conform to the standards outlined in CONTRIBUTING.md.

@SupremoUGH SupremoUGH self-assigned this Aug 22, 2022
@bhgomes bhgomes added the P-low Priority: Low label Aug 29, 2022
bhgomes and others added 10 commits August 31, 2022 18:26
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
@bhgomes bhgomes changed the title Feat/test benchmark suite crypto primitives DO NOT MERGE: Feat/test benchmark suite crypto primitives Oct 27, 2022
@bhgomes bhgomes added the DO-NOT-MERGE Labels a PR that should not be merged label Oct 27, 2022
@bhgomes bhgomes mentioned this pull request Dec 7, 2022
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DO-NOT-MERGE Labels a PR that should not be merged P-low Priority: Low
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test/Benchmark Crypto Primitives Tracking Issue
2 participants