Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dex swap fees #1

Open
wants to merge 10 commits into
base: polkadot-v0.9.37
Choose a base branch
from
Open

Dex swap fees #1

wants to merge 10 commits into from

Conversation

ghzlatarev
Copy link

@ghzlatarev ghzlatarev commented Aug 29, 2023 •
edited

  • Add a configurable fee that is only when, in a swap, the asset supplied by the user is the native asset of the chain, then there's a fee that gets collected in a pot account
  • Fix tests

@ghzlatarev
Iniitail
42ad51e 
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
@ghzlatarev
Clean up tests
fca2183 
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
@ghzlatarev
Rfemove unused extrinsic
f4123e6 
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
@ghzlatarev
Unwrap or 0 for swap fee
162ff63 
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
@ghzlatarev ghzlatarev mentioned this pull request Aug 30, 2023
Open
9 tasks
ferrell-code
ferrell-code reviewed Aug 30, 2023
View reviewed changes
Copy link

@ferrell-code ferrell-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also a lot of the tests fail for zenlink-protocol

zenlink-protocol/src/primitives.rs Outdated Show resolved Hide resolved
zenlink-protocol/src/swap/mod.rs Outdated Show resolved Hide resolved
@ghzlatarev
Copy link
Author

Also a lot of the tests fail for zenlink-protocol

ah good catch, my second to alst commit included some extra stuff that wasnt supposed to be committed.

@ghzlatarev
saturating sub
e8d977e 
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
@ghzlatarev
Revert erronous commit
d822d72 
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
@ghzlatarev
Update type name
810ac47 
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
@ghzlatarev
Update names
01b0cd4 
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
@ghzlatarev
Make fees factor a configurable storage item
b1d9287 
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
@ghzlatarev
Add a set extrinsic for the fees factor storage item
c581a0b 
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ferrell-code ferrell-code ferrell-code approved these changes

@zqhxuyuan zqhxuyuan Awaiting requested review from zqhxuyuan

@Dengjianping Dengjianping Awaiting requested review from Dengjianping

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@ghzlatarev @ferrell-code