Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix xcm benchmark tests #1333

Merged
merged 63 commits into from May 18, 2024
Merged

Fix xcm benchmark tests #1333

merged 63 commits into from May 18, 2024

Conversation

Dengjianping
Copy link
Contributor

@Dengjianping Dengjianping commented May 9, 2024 •
edited

Description

Before we can approve this PR for merge, please make sure that all the following items have been checked off:

  • Connected to an issue with discussion and accepted design using zenhub "Connect issue" button below
  • Added one label out of the L- group to this PR
  • Added one or more labels from the A- and C- groups to this PR
  • Explicitly labelled A-calamari and/or A-manta if your changes are meant for/impact either of these (CI depends on it)
  • Re-reviewed Files changed in the Github PR explorer.
  • Add A-integration-test-checks to run start-integration-test-checks (Required)
  • Add A-benchmark-checks to run start-benchmark-check (Required)
  • Add A-unit-test-checks to run start-unit-test-checks (Required)
  • Add A-congestion-test-checks to run start-integration-test-checks (Optional)

Situational Notes:

  • If adding functionality, write unit tests!
  • If importing a new pallet, choose a proper module index for it, and allow it in BaseFilter. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.
  • If needed, update our Javascript/Typescript APIs. These APIs are officially used by exchanges or community developers.
  • If modifying existing runtime storage items, make sure to implement storage migrations for the runtime and test them with try-runtime. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of #[pallet::storage] items to check for any.

@ferrell-code
update to v1.6.0
6225a29 
Signed-off-by: Charles Ferrell <charlie@manta.network>
@ferrell-code
update primitives
f3994e6 
Signed-off-by: Charles Ferrell <charlie@manta.network>
@ferrell-code
bump a few pallets
dba5130 
Signed-off-by: Charles Ferrell <charlie@manta.network>
@ferrell-code
compile more pallets
403605e 
Signed-off-by: Charles Ferrell <charlie@manta.network>
@ferrell-code
[no-ci] finish compiling pallets
a7adb80 
Signed-off-by: Charles Ferrell <charlie@manta.network>
@ferrell-code
[no ci] update calamari
bbe7334 
Signed-off-by: Charles Ferrell <charlie@manta.network>
@ferrell-code
calamari xcmp module configuration
a7ef2e0 
Signed-off-by: Charles Ferrell <charlie@manta.network>
@ferrell-code
[no ci] compile calamari runtime
86c9230 
Signed-off-by: Charles Ferrell <charlie@manta.network>
@ferrell-code
[no ci] get lottery test to compile
c8b68b2 
Signed-off-by: Charles Ferrell <charlie@manta.network>
@ferrell-code
[no ci] manta runtime update
e141110 
Signed-off-by: Charles Ferrell <charlie@manta.network>
@ferrell-code
[no ci] update client
5ca69b4 
Signed-off-by: Charles Ferrell <charlie@manta.network>
@ferrell-code
[no ci] some client fixes and add rust toolchain info
81917bd 
Signed-off-by: Charles Ferrell <charlie@manta.network>
@ferrell-code
[no ci] compile node, a bit broken still
e148335 
Signed-off-by: Charles Ferrell <charlie@manta.network>
@ferrell-code
[no ci] wip integration test fix
2d0206c 
Signed-off-by: Charles Ferrell <charlie@manta.network>
@ferrell-code
[no ci] fix integration test
561fbb9 
Signed-off-by: Charles Ferrell <charlie@manta.network>
@ferrell-code
[no ci] update mocks to correctly process xcm
f95946a 
Signed-off-by: Charles Ferrell <charlie@manta.network>
@ferrell-code
[no ci] compile calamari integration test
e370a57 
Signed-off-by: Charles Ferrell <charlie@manta.network>
@ferrell-code
[no ci] runtime benchmarks fix
49cee80 
Signed-off-by: Charles Ferrell <charlie@manta.network>
@ferrell-code
[no ci] runtime benchmarks now compiles
e0dd42d 
Signed-off-by: Charles Ferrell <charlie@manta.network>
@ferrell-code
[no ci] Fix some warnings
0f3bc42 
Signed-off-by: Charles Ferrell <charlie@manta.network>
@ferrell-code
fix some failed integration tests
5afd98d 
Signed-off-by: Charles Ferrell <charlie@manta.network>
@ferrell-code
[no ci] fix more integration test
9929ead 
Signed-off-by: Charles Ferrell <charlie@manta.network>
@ferrell-code
[no ci] fix tx pause unit tests
644e3f3 
Signed-off-by: Charles Ferrell <charlie@manta.network>
@ferrell-code
[no ci] fix tx pause tests
50acb9e 
Signed-off-by: Charles Ferrell <charlie@manta.network>
@ferrell-code
[no ci] fix some client issue
0f41be4 
Signed-off-by: Charles Ferrell <charlie@manta.network>
@ferrell-code
[no ci] clean up chain specs
34b8cd9 
Signed-off-by: Charles Ferrell <charlie@manta.network>
@ferrell-code
[no ci] try-runtime to work
1479a3d 
Signed-off-by: Charles Ferrell <charlie@manta.network>
@ferrell-code
[no ci] use nimbus consensus... uses deprecated function for now
de31046 
Signed-off-by: Charles Ferrell <charlie@manta.network>
@ferrell-code
[no ci] add concrete weight values
7a30fff 
Signed-off-by: Charles Ferrell <charlie@manta.network>
@ferrell-code
update ci
18b1c5a 
Signed-off-by: Charles Ferrell <charlie@manta.network>
Dengjianping and others added 8 commits April 18, 2024 18:35
@Dengjianping
Fix aura block importing
258c84e 
Signed-off-by: Dengjianping <djptux@gmail.com>
@ferrell-code
fix block import to use delayed best block
05f0876 
Signed-off-by: Charles Ferrell <charlie@manta.network>
@ferrell-code
fix benchmarking
cf2559d 
Signed-off-by: Charles Ferrell <charlie@manta.network>
@ferrell-code
fix benchmark
d6effc3 
Signed-off-by: Charles Ferrell <charlie@manta.network>
@ferrell-code
update treasury in manta to spend via root
f16625d 
Signed-off-by: Charles Ferrell <charlie@manta.network>
@Dengjianping
Fix xcm benchmarking
8baf332 
Signed-off-by: Jamie <djptux@gmail.com>
@Dengjianping
Merge manta branch
4ecb9c0 
Signed-off-by: Jamie <djptux@gmail.com>
@Dengjianping
Fix clippy
6d5d83b 
Signed-off-by: Jamie <djptux@gmail.com>
@Dengjianping Dengjianping self-assigned this May 13, 2024
@Dengjianping Dengjianping added A-manta Area: Issues and PRs related to the Manta Runtime A-calamari Area: Issues and PRs related to the Calamari Runtime A-ci Area: Continuous Integration A-testing Area: Testing-related Issues and PRs L-fixed Log: Issues and PRs related to bug fixes A-benchmark-checks A-unit-test-checks A-integration-test-checks labels May 13, 2024
@Dengjianping
Fix tests
82f8674 
Signed-off-by: Jamie <djptux@gmail.com>
@Dengjianping
Fix fmt
087ce65 
Signed-off-by: Jamie <djptux@gmail.com>
ferrell-code
ferrell-code reviewed May 14, 2024
View reviewed changes
Copy link
Contributor

@ferrell-code ferrell-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

xcm fungible benchmark still fails right? does in ci

@Dengjianping
Fix xcm benchmarking
fabb21a 
Signed-off-by: Jamie <djptux@gmail.com>
@Dengjianping
Copy link
Contributor Author

Dengjianping commented May 15, 2024 •
edited

xcm fungible benchmark still fails right? does in ci

My bad, I moved asset creation after asset registration.
Now it should be fixed.

@Dengjianping
Fix tests
2151491 
Signed-off-by: Jamie <djptux@gmail.com>
ferrell-code
ferrell-code approved these changes May 15, 2024
View reviewed changes
Copy link
Contributor

@ferrell-code ferrell-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@Dengjianping
Fix benchmarkng
1ca8072 
Signed-off-by: Jamie <djptux@gmail.com>
@Dengjianping Dengjianping merged commit faaf9dc into manta May 18, 2024
20 checks passed
@Dengjianping Dengjianping deleted the fix-xcm-benchmark-tests branch May 18, 2024 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ferrell-code ferrell-code ferrell-code approved these changes

@anaye1997 anaye1997 anaye1997 approved these changes

@zqhxuyuan zqhxuyuan Awaiting requested review from zqhxuyuan

Assignees

@Dengjianping Dengjianping

Labels
A-benchmark-checks A-calamari Area: Issues and PRs related to the Calamari Runtime A-ci Area: Continuous Integration A-integration-test-checks A-manta Area: Issues and PRs related to the Manta Runtime A-testing Area: Testing-related Issues and PRs A-unit-test-checks L-fixed Log: Issues and PRs related to bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Dengjianping @ferrell-code @anaye1997