Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release v4.6.0 #1277

Merged
merged 5 commits into from Dec 22, 2023
Merged

Release v4.6.0 #1277

merged 5 commits into from Dec 22, 2023

Conversation

Dengjianping
Copy link
Contributor

@Dengjianping Dengjianping commented Dec 19, 2023 •
edited

Description

Closes #1276

Before we can approve this PR for merge, please make sure that all the following items have been checked off:

  • Connected to an issue with discussion and accepted design using zenhub "Connect issue" button below
  • Added one label out of the L- group to this PR
  • Added one or more labels from the A- and C- groups to this PR
  • Explicitly labelled A-calamari and/or A-manta if your changes are meant for/impact either of these (CI depends on it)
  • Re-reviewed Files changed in the Github PR explorer.
  • Add A-integration-test-checks to run start-integration-test-checks (Required)
  • Add A-benchmark-checks to run start-benchmark-check (Required)
  • Add A-unit-test-checks to run start-unit-test-checks (Required)
  • Add A-congestion-test-checks to run start-integration-test-checks (Optional)

Situational Notes:

  • If adding functionality, write unit tests!
  • If importing a new pallet, choose a proper module index for it, and allow it in BaseFilter. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.
  • If needed, update our Javascript/Typescript APIs. These APIs are officially used by exchanges or community developers.
  • If modifying existing runtime storage items, make sure to implement storage migrations for the runtime and test them with try-runtime. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of #[pallet::storage] items to check for any.

@Dengjianping
Bump version
79ae2f3 
Signed-off-by: Dengjianping <djptux@gmail.com>
@Dengjianping Dengjianping added A-manta Area: Issues and PRs related to the Manta Runtime A-calamari Area: Issues and PRs related to the Calamari Runtime A-runtime Area: Issues and PRs related to Runtimes A-testing Area: Testing-related Issues and PRs A-unit-test-checks A-benchmark-checks C-enhancement Category: An issue proposing an enhancement or a PR with one L-release Related to a release A-integration-test-checks L-fixed Log: Issues and PRs related to bug fixes labels Dec 19, 2023
ghzlatarev
ghzlatarev previously approved these changes Dec 19, 2023
View reviewed changes
@Dengjianping
Copy link
Contributor Author

manta runtime metadata diff result:

[Spec] name: manta
spec_version: 4400 -> 4600
transaction_version: 4 -> 7
[Metadata] version: 14
[Modules] num: 39 -> 38
[-] modules: MantaPay

                      [System] idx: 0 (calls: 8, storage: 17)

             [ParachainSystem] idx: 1 (calls: 4, storage: 22)
                          [authorizeUpgrade] idx: 2 (args: 1 -> 2)
                                             (H256) -> (H256, bool)
                            [validationData] type: Option<PolkadotPrimitivesV2PersistedValidationData> -> Option<PolkadotPrimitivesV4PersistedValidationData>
                  [upgradeRestrictionSignal] type: Option<PolkadotPrimitivesV2UpgradeRestriction> -> Option<PolkadotPrimitivesV4UpgradeRestriction>
                         [hostConfiguration] type: Option<PolkadotPrimitivesV2AbridgedHostConfiguration> -> Option<PolkadotPrimitivesV4AbridgedHostConfiguration>
                         [authorizedUpgrade] type: Option<H256> -> Option<CumulusPalletParachainSystemCodeUpgradeAuthorization>

                   [Timestamp] idx: 2 (calls: 1, storage: 3)

            [TransactionPause] idx: 9 (calls: 6, storage: 2)

                    [Balances] idx: 10 (calls: 6 -> 9, storage: 6 -> 8)
                               [+] calls: transferAllowDeath, setBalanceDeprecated, upgradeAccounts, forceSetBalance
                               [-] calls: setBalance
                                  [transfer] idx: 0 -> 7 (args: 2)
                                             (MultiAddress, Compact<u128>)
                               [+] storage: holds, freezes

                   [Democracy] idx: 14 (calls: 18 -> 19, storage: 12 -> 13)
                               [+] calls: setMetadata
                               [+] storage: metadataOf

                     [Council] idx: 15 (calls: 7 -> 6, storage: 7)
                               [-] calls: closeOldWeight

           [CouncilMembership] idx: 16 (calls: 7, storage: 3)

          [TechnicalCommittee] idx: 17 (calls: 7 -> 6, storage: 7)
                               [-] calls: closeOldWeight

         [TechnicalMembership] idx: 18 (calls: 7, storage: 3)

            [ParachainStaking] idx: 48 (calls: 26, storage: 19)

              [AuthorInherent] idx: 60 (calls: 1, storage: 3)

                  [Authorship] idx: 20 -> - (calls: 1 -> 0, storage: 4 -> 2)
                               [-] calls: setUncles
                               [-] storage: uncles, didSetUncles

           [CollatorSelection] idx: 21 (calls: 9, storage: 8)

                     [Session] idx: 22 (calls: 2, storage: 8)

                    [Treasury] idx: 26 (calls: 5, storage: 5)

                    [Preimage] idx: 28 (calls: 4, storage: 3)

                   [Scheduler] idx: 29 (calls: 6, storage: 4)

                   [XcmpQueue] idx: 30 (calls: 9, storage: 10 -> 11)
                         [serviceOverweight] idx: 0 (args: 2)
                                             (u64, u64) -> (u64, SpWeightsWeightV2Weight)
                     [updateThresholdWeight] idx: 6 (args: 1)
                                             (u64) -> (SpWeightsWeightV2Weight)
                 [updateWeightRestrictDecay] idx: 7 (args: 1)
                                             (u64) -> (SpWeightsWeightV2Weight)
             [updateXcmpMaxIndividualWeight] idx: 8 (args: 1)
                                             (u64) -> (SpWeightsWeightV2Weight)
                               [+] storage: counterForOverweight

                 [PolkadotXcm] idx: 31 (calls: 10 -> 11, storage: 10 -> 13)
                               [+] calls: forceSuspension
                                   [execute] idx: 3 (args: 2)
                                             (XcmVersionedXcm, u64) -> (XcmVersionedXcm, SpWeightsWeightV2Weight)
                           [forceXcmVersion] idx: 4 (args: 2)
                                             (XcmV1MultiLocation, u32) -> (XcmV3MultiLocation, u32)
              [limitedReserveTransferAssets] idx: 8 (args: 5)
                                             (XcmVersionedMultiLocation, XcmVersionedMultiLocation, XcmVersionedMultiAssets, u32, XcmV2WeightLimit) -> (XcmVersionedMultiLocation, XcmVersionedMultiLocation, XcmVersionedMultiAssets, u32, XcmV3WeightLimit)
                     [limitedTeleportAssets] idx: 9 (args: 5)
                                             (XcmVersionedMultiLocation, XcmVersionedMultiLocation, XcmVersionedMultiAssets, u32, XcmV2WeightLimit) -> (XcmVersionedMultiLocation, XcmVersionedMultiLocation, XcmVersionedMultiAssets, u32, XcmV3WeightLimit)
                               [+] storage: remoteLockedFungibles, lockedFungibles, xcmExecutionSuspended
                      [versionNotifyTargets] value: (u64,u64,u32) -> (u64,SpWeightsWeightV2Weight,u32)

                    [DmpQueue] idx: 33 (calls: 1, storage: 5 -> 6)
                         [serviceOverweight] idx: 0 (args: 2)
                                             (u64, u64) -> (u64, SpWeightsWeightV2Weight)
                               [+] storage: counterForOverweight

                     [XTokens] idx: 34 (calls: 6, storage: 1)
                                  [transfer] idx: 0 (args: 4)
                                             (MantaRuntimeXcmConfigCurrencyId, u128, XcmVersionedMultiLocation, XcmV2WeightLimit) -> (MantaRuntimeXcmConfigCurrencyId, u128, XcmVersionedMultiLocation, XcmV3WeightLimit)
                        [transferMultiasset] idx: 1 (args: 3)
                                             (XcmVersionedMultiAsset, XcmVersionedMultiLocation, XcmV2WeightLimit) -> (XcmVersionedMultiAsset, XcmVersionedMultiLocation, XcmV3WeightLimit)
                           [transferWithFee] idx: 2 (args: 5)
                                             (MantaRuntimeXcmConfigCurrencyId, u128, u128, XcmVersionedMultiLocation, XcmV2WeightLimit) -> (MantaRuntimeXcmConfigCurrencyId, u128, u128, XcmVersionedMultiLocation, XcmV3WeightLimit)
                 [transferMultiassetWithFee] idx: 3 (args: 4)
                                             (XcmVersionedMultiAsset, XcmVersionedMultiAsset, XcmVersionedMultiLocation, XcmV2WeightLimit) -> (XcmVersionedMultiAsset, XcmVersionedMultiAsset, XcmVersionedMultiLocation, XcmV3WeightLimit)
                   [transferMulticurrencies] idx: 4 (args: 4)
                                             (Vec<(MantaRuntimeXcmConfigCurrencyId,u128)>, u32, XcmVersionedMultiLocation, XcmV2WeightLimit) -> (Vec<(MantaRuntimeXcmConfigCurrencyId,u128)>, u32, XcmVersionedMultiLocation, XcmV3WeightLimit)
                       [transferMultiassets] idx: 5 (args: 4)
                                             (XcmVersionedMultiAssets, u32, XcmVersionedMultiLocation, XcmV2WeightLimit) -> (XcmVersionedMultiAssets, u32, XcmVersionedMultiLocation, XcmV3WeightLimit)

                    [Multisig] idx: 41 (calls: 4, storage: 2)

                        [Sudo] idx: 42 (calls: 4, storage: 2)

                      [Assets] idx: 45 (calls: 28 -> 32, storage: 5)
                               [+] calls: setMinBalance, touchOther, refundOther, block

                [AssetManager] idx: 46 (calls: 9, storage: 12)

                    [MantaSbt] idx: 49 (calls: 13, storage: 14)

                 [NameService] idx: 52 (calls: 5, storage: 4)

             [ZenlinkProtocol] idx: 51 (calls: 16, storage: 12)
                            [setFeeReceiver] idx: 0 (args: 1)
                                             (Option<AccountId32>) -> (Option<MultiAddress>)
                                  [transfer] idx: 2 (args: 3)
                                             (ZenlinkProtocolPrimitivesAssetId, AccountId32, Compact<u128>) -> (ZenlinkProtocolPrimitivesAssetId, MultiAddress, Compact<u128>)
                                [createPair] idx: 4 -> 3 (args: 2)
                                             (ZenlinkProtocolPrimitivesAssetId, ZenlinkProtocolPrimitivesAssetId)
                              [addLiquidity] idx: 5 -> 4 (args: 7)
                                             (ZenlinkProtocolPrimitivesAssetId, ZenlinkProtocolPrimitivesAssetId, Compact<u128>, Compact<u128>, Compact<u128>, Compact<u128>, Compact<u32>)
                           [removeLiquidity] idx: 6 -> 5 (args: 7)
                                             (ZenlinkProtocolPrimitivesAssetId, ZenlinkProtocolPrimitivesAssetId, Compact<u128>, Compact<u128>, Compact<u128>, AccountId32, Compact<u32>) -> (ZenlinkProtocolPrimitivesAssetId, ZenlinkProtocolPrimitivesAssetId, Compact<u128>, Compact<u128>, Compact<u128>, MultiAddress, Compact<u32>)
                  [swapExactAssetsForAssets] idx: 7 -> 6 (args: 5)
                                             (Compact<u128>, Compact<u128>, Vec<ZenlinkProtocolPrimitivesAssetId>, AccountId32, Compact<u32>) -> (Compact<u128>, Compact<u128>, Vec<ZenlinkProtocolPrimitivesAssetId>, MultiAddress, Compact<u32>)
                  [swapAssetsForExactAssets] idx: 8 -> 7 (args: 5)
                                             (Compact<u128>, Compact<u128>, Vec<ZenlinkProtocolPrimitivesAssetId>, AccountId32, Compact<u32>) -> (Compact<u128>, Compact<u128>, Vec<ZenlinkProtocolPrimitivesAssetId>, MultiAddress, Compact<u32>)
                           [bootstrapCreate] idx: 9 -> 8 (args: 9)
                                             (ZenlinkProtocolPrimitivesAssetId, ZenlinkProtocolPrimitivesAssetId, Compact<u128>, Compact<u128>, Compact<u128>, Compact<u128>, Compact<u32>, Vec<ZenlinkProtocolPrimitivesAssetId>, Vec<(ZenlinkProtocolPrimitivesAssetId,u128)>)
                       [bootstrapContribute] idx: 10 -> 9 (args: 5)
                                             (ZenlinkProtocolPrimitivesAssetId, ZenlinkProtocolPrimitivesAssetId, Compact<u128>, Compact<u128>, Compact<u32>)
                            [bootstrapClaim] idx: 11 -> 10 (args: 4)
                                             (AccountId32, ZenlinkProtocolPrimitivesAssetId, ZenlinkProtocolPrimitivesAssetId, Compact<u32>) -> (MultiAddress, ZenlinkProtocolPrimitivesAssetId, ZenlinkProtocolPrimitivesAssetId, Compact<u32>)
                              [bootstrapEnd] idx: 12 -> 11 (args: 2)
                                             (ZenlinkProtocolPrimitivesAssetId, ZenlinkProtocolPrimitivesAssetId)
                           [bootstrapUpdate] idx: 13 -> 12 (args: 9)
                                             (ZenlinkProtocolPrimitivesAssetId, ZenlinkProtocolPrimitivesAssetId, Compact<u128>, Compact<u128>, Compact<u128>, Compact<u128>, Compact<u32>, Vec<ZenlinkProtocolPrimitivesAssetId>, Vec<(ZenlinkProtocolPrimitivesAssetId,u128)>)
                           [bootstrapRefund] idx: 14 -> 13 (args: 2)
                                             (ZenlinkProtocolPrimitivesAssetId, ZenlinkProtocolPrimitivesAssetId)
                     [bootstrapChargeReward] idx: 16 -> 14 (args: 3)
                                             (ZenlinkProtocolPrimitivesAssetId, ZenlinkProtocolPrimitivesAssetId, Vec<(ZenlinkProtocolPrimitivesAssetId,u128)>)
                   [bootstrapWithdrawReward] idx: 17 -> 15 (args: 3)
                                             (ZenlinkProtocolPrimitivesAssetId, ZenlinkProtocolPrimitivesAssetId, AccountId32) -> (ZenlinkProtocolPrimitivesAssetId, ZenlinkProtocolPrimitivesAssetId, MultiAddress)

                     [Farming] idx: 54 (calls: 14, storage: 8)

                  [Randomness] idx: 70 (calls: 1, storage: 4)

                     [Lottery] idx: 71 (calls: 12 -> 13, storage: 16 -> 17)
                               [+] calls: setFarmingParams
                               [+] storage: farmingParameters

@Dengjianping
Copy link
Contributor Author

calamari runtime metadata diff result:

[Spec] name: calamari
spec_version: 4401 -> 4600
transaction_version: 16 -> 18
[Metadata] version: 14
[Modules] num: 39

                      [System] idx: 0 (calls: 8, storage: 17)

             [ParachainSystem] idx: 1 (calls: 4, storage: 22)
                          [authorizeUpgrade] idx: 2 (args: 1 -> 2)
                                             (H256) -> (H256, bool)
                            [validationData] type: Option<PolkadotPrimitivesV2PersistedValidationData> -> Option<PolkadotPrimitivesV4PersistedValidationData>
                  [upgradeRestrictionSignal] type: Option<PolkadotPrimitivesV2UpgradeRestriction> -> Option<PolkadotPrimitivesV4UpgradeRestriction>
                         [hostConfiguration] type: Option<PolkadotPrimitivesV2AbridgedHostConfiguration> -> Option<PolkadotPrimitivesV4AbridgedHostConfiguration>
                         [authorizedUpgrade] type: Option<H256> -> Option<CumulusPalletParachainSystemCodeUpgradeAuthorization>

                   [Timestamp] idx: 2 (calls: 1, storage: 3)

            [TransactionPause] idx: 9 (calls: 6, storage: 2)

                    [Balances] idx: 10 (calls: 6 -> 9, storage: 6 -> 8)
                               [+] calls: transferAllowDeath, setBalanceDeprecated, upgradeAccounts, forceSetBalance
                               [-] calls: setBalance
                                  [transfer] idx: 0 -> 7 (args: 2)
                                             (MultiAddress, Compact<u128>)
                               [+] storage: holds, freezes

                   [Democracy] idx: 14 (calls: 18 -> 19, storage: 12 -> 13)
                               [+] calls: setMetadata
                               [+] storage: metadataOf

                     [Council] idx: 15 (calls: 7 -> 6, storage: 7)
                               [-] calls: closeOldWeight

           [CouncilMembership] idx: 16 (calls: 7, storage: 3)

          [TechnicalCommittee] idx: 17 (calls: 7 -> 6, storage: 7)
                               [-] calls: closeOldWeight

         [TechnicalMembership] idx: 18 (calls: 7, storage: 3)

            [ParachainStaking] idx: 48 (calls: 26, storage: 19)

              [AuthorInherent] idx: 60 (calls: 1, storage: 3)

                  [Authorship] idx: 20 -> - (calls: 1 -> 0, storage: 4 -> 2)
                               [-] calls: setUncles
                               [-] storage: uncles, didSetUncles

           [CollatorSelection] idx: 21 (calls: 9, storage: 8)

                     [Session] idx: 22 (calls: 2, storage: 8)

                    [Treasury] idx: 26 (calls: 5, storage: 5)

                    [Preimage] idx: 28 (calls: 4, storage: 3)

                   [Scheduler] idx: 29 (calls: 6, storage: 4)

                   [XcmpQueue] idx: 30 (calls: 9, storage: 10 -> 11)
                         [serviceOverweight] idx: 0 (args: 2)
                                             (u64, u64) -> (u64, SpWeightsWeightV2Weight)
                     [updateThresholdWeight] idx: 6 (args: 1)
                                             (u64) -> (SpWeightsWeightV2Weight)
                 [updateWeightRestrictDecay] idx: 7 (args: 1)
                                             (u64) -> (SpWeightsWeightV2Weight)
             [updateXcmpMaxIndividualWeight] idx: 8 (args: 1)
                                             (u64) -> (SpWeightsWeightV2Weight)
                               [+] storage: counterForOverweight

                 [PolkadotXcm] idx: 31 (calls: 10 -> 11, storage: 10 -> 13)
                               [+] calls: forceSuspension
                                   [execute] idx: 3 (args: 2)
                                             (XcmVersionedXcm, u64) -> (XcmVersionedXcm, SpWeightsWeightV2Weight)
                           [forceXcmVersion] idx: 4 (args: 2)
                                             (XcmV1MultiLocation, u32) -> (XcmV3MultiLocation, u32)
              [limitedReserveTransferAssets] idx: 8 (args: 5)
                                             (XcmVersionedMultiLocation, XcmVersionedMultiLocation, XcmVersionedMultiAssets, u32, XcmV2WeightLimit) -> (XcmVersionedMultiLocation, XcmVersionedMultiLocation, XcmVersionedMultiAssets, u32, XcmV3WeightLimit)
                     [limitedTeleportAssets] idx: 9 (args: 5)
                                             (XcmVersionedMultiLocation, XcmVersionedMultiLocation, XcmVersionedMultiAssets, u32, XcmV2WeightLimit) -> (XcmVersionedMultiLocation, XcmVersionedMultiLocation, XcmVersionedMultiAssets, u32, XcmV3WeightLimit)
                               [+] storage: remoteLockedFungibles, lockedFungibles, xcmExecutionSuspended
                      [versionNotifyTargets] value: (u64,u64,u32) -> (u64,SpWeightsWeightV2Weight,u32)

                    [DmpQueue] idx: 33 (calls: 1, storage: 5 -> 6)
                         [serviceOverweight] idx: 0 (args: 2)
                                             (u64, u64) -> (u64, SpWeightsWeightV2Weight)
                               [+] storage: counterForOverweight

                     [XTokens] idx: 34 (calls: 6, storage: 1)
                                  [transfer] idx: 0 (args: 4)
                                             (CalamariRuntimeXcmConfigCurrencyId, u128, XcmVersionedMultiLocation, XcmV2WeightLimit) -> (CalamariRuntimeXcmConfigCurrencyId, u128, XcmVersionedMultiLocation, XcmV3WeightLimit)
                        [transferMultiasset] idx: 1 (args: 3)
                                             (XcmVersionedMultiAsset, XcmVersionedMultiLocation, XcmV2WeightLimit) -> (XcmVersionedMultiAsset, XcmVersionedMultiLocation, XcmV3WeightLimit)
                           [transferWithFee] idx: 2 (args: 5)
                                             (CalamariRuntimeXcmConfigCurrencyId, u128, u128, XcmVersionedMultiLocation, XcmV2WeightLimit) -> (CalamariRuntimeXcmConfigCurrencyId, u128, u128, XcmVersionedMultiLocation, XcmV3WeightLimit)
                 [transferMultiassetWithFee] idx: 3 (args: 4)
                                             (XcmVersionedMultiAsset, XcmVersionedMultiAsset, XcmVersionedMultiLocation, XcmV2WeightLimit) -> (XcmVersionedMultiAsset, XcmVersionedMultiAsset, XcmVersionedMultiLocation, XcmV3WeightLimit)
                   [transferMulticurrencies] idx: 4 (args: 4)
                                             (Vec<(CalamariRuntimeXcmConfigCurrencyId,u128)>, u32, XcmVersionedMultiLocation, XcmV2WeightLimit) -> (Vec<(CalamariRuntimeXcmConfigCurrencyId,u128)>, u32, XcmVersionedMultiLocation, XcmV3WeightLimit)
                       [transferMultiassets] idx: 5 (args: 4)
                                             (XcmVersionedMultiAssets, u32, XcmVersionedMultiLocation, XcmV2WeightLimit) -> (XcmVersionedMultiAssets, u32, XcmVersionedMultiLocation, XcmV3WeightLimit)

                    [Multisig] idx: 41 (calls: 4, storage: 2)

                      [Assets] idx: 45 (calls: 28 -> 32, storage: 5)
                               [+] calls: setMinBalance, touchOther, refundOther, block

                [AssetManager] idx: 46 (calls: 9, storage: 12)

                    [MantaPay] idx: 47 (calls: 4, storage: 8)

                    [MantaSbt] idx: 49 (calls: 13, storage: 14)

                 [NameService] idx: 52 (calls: 5, storage: 4)

             [CalamariVesting] idx: 50 (calls: 3, storage: 3)

             [ZenlinkProtocol] idx: 51 (calls: 16, storage: 12)
                            [setFeeReceiver] idx: 0 (args: 1)
                                             (Option<AccountId32>) -> (Option<MultiAddress>)
                                  [transfer] idx: 2 (args: 3)
                                             (ZenlinkProtocolPrimitivesAssetId, AccountId32, Compact<u128>) -> (ZenlinkProtocolPrimitivesAssetId, MultiAddress, Compact<u128>)
                                [createPair] idx: 4 -> 3 (args: 2)
                                             (ZenlinkProtocolPrimitivesAssetId, ZenlinkProtocolPrimitivesAssetId)
                              [addLiquidity] idx: 5 -> 4 (args: 7)
                                             (ZenlinkProtocolPrimitivesAssetId, ZenlinkProtocolPrimitivesAssetId, Compact<u128>, Compact<u128>, Compact<u128>, Compact<u128>, Compact<u32>)
                           [removeLiquidity] idx: 6 -> 5 (args: 7)
                                             (ZenlinkProtocolPrimitivesAssetId, ZenlinkProtocolPrimitivesAssetId, Compact<u128>, Compact<u128>, Compact<u128>, AccountId32, Compact<u32>) -> (ZenlinkProtocolPrimitivesAssetId, ZenlinkProtocolPrimitivesAssetId, Compact<u128>, Compact<u128>, Compact<u128>, MultiAddress, Compact<u32>)
                  [swapExactAssetsForAssets] idx: 7 -> 6 (args: 5)
                                             (Compact<u128>, Compact<u128>, Vec<ZenlinkProtocolPrimitivesAssetId>, AccountId32, Compact<u32>) -> (Compact<u128>, Compact<u128>, Vec<ZenlinkProtocolPrimitivesAssetId>, MultiAddress, Compact<u32>)
                  [swapAssetsForExactAssets] idx: 8 -> 7 (args: 5)
                                             (Compact<u128>, Compact<u128>, Vec<ZenlinkProtocolPrimitivesAssetId>, AccountId32, Compact<u32>) -> (Compact<u128>, Compact<u128>, Vec<ZenlinkProtocolPrimitivesAssetId>, MultiAddress, Compact<u32>)
                           [bootstrapCreate] idx: 9 -> 8 (args: 9)
                                             (ZenlinkProtocolPrimitivesAssetId, ZenlinkProtocolPrimitivesAssetId, Compact<u128>, Compact<u128>, Compact<u128>, Compact<u128>, Compact<u32>, Vec<ZenlinkProtocolPrimitivesAssetId>, Vec<(ZenlinkProtocolPrimitivesAssetId,u128)>)
                       [bootstrapContribute] idx: 10 -> 9 (args: 5)
                                             (ZenlinkProtocolPrimitivesAssetId, ZenlinkProtocolPrimitivesAssetId, Compact<u128>, Compact<u128>, Compact<u32>)
                            [bootstrapClaim] idx: 11 -> 10 (args: 4)
                                             (AccountId32, ZenlinkProtocolPrimitivesAssetId, ZenlinkProtocolPrimitivesAssetId, Compact<u32>) -> (MultiAddress, ZenlinkProtocolPrimitivesAssetId, ZenlinkProtocolPrimitivesAssetId, Compact<u32>)
                              [bootstrapEnd] idx: 12 -> 11 (args: 2)
                                             (ZenlinkProtocolPrimitivesAssetId, ZenlinkProtocolPrimitivesAssetId)
                           [bootstrapUpdate] idx: 13 -> 12 (args: 9)
                                             (ZenlinkProtocolPrimitivesAssetId, ZenlinkProtocolPrimitivesAssetId, Compact<u128>, Compact<u128>, Compact<u128>, Compact<u128>, Compact<u32>, Vec<ZenlinkProtocolPrimitivesAssetId>, Vec<(ZenlinkProtocolPrimitivesAssetId,u128)>)
                           [bootstrapRefund] idx: 14 -> 13 (args: 2)
                                             (ZenlinkProtocolPrimitivesAssetId, ZenlinkProtocolPrimitivesAssetId)
                     [bootstrapChargeReward] idx: 16 -> 14 (args: 3)
                                             (ZenlinkProtocolPrimitivesAssetId, ZenlinkProtocolPrimitivesAssetId, Vec<(ZenlinkProtocolPrimitivesAssetId,u128)>)
                   [bootstrapWithdrawReward] idx: 17 -> 15 (args: 3)
                                             (ZenlinkProtocolPrimitivesAssetId, ZenlinkProtocolPrimitivesAssetId, AccountId32) -> (ZenlinkProtocolPrimitivesAssetId, ZenlinkProtocolPrimitivesAssetId, MultiAddress)

                     [Farming] idx: 54 (calls: 14, storage: 8)

                  [Randomness] idx: 70 (calls: 1, storage: 4)

                     [Lottery] idx: 71 (calls: 12 -> 13, storage: 16 -> 17)
                               [+] calls: setFarmingParams
                               [+] storage: farmingParameters

@Dengjianping
Copy link
Contributor Author

Dengjianping commented Dec 20, 2023 •
edited

We have problem on diffing runtime metatada, I failed to reproduce it locally. I created an issue to track it #1278, so won't fix it in this release. And I posted all diff result above, and the result shows we have to bump tx version(already bumped).

@ghzlatarev
Copy link
Contributor

ghzlatarev commented Dec 20, 2023 •
edited

Didn't we update the weights in the last PR ? Or do we need to do it again ?
edit: ah you ran it on your own machine.

One of yesterday's runs succeeded though but not sure if its Manta or Calamari https://github.com/Manta-Network/Manta/actions/runs/7262536984
edit: Seems like its Manta run because it tried to benchmark zenlink

@Dengjianping
Copy link
Contributor Author

Didn't we update the weights in the last PR ? Or do we need to do it again ? edit: ah you ran it on your own machine.

One of yesterday's runs succeeded though but not sure if its Manta or Calamari https://github.com/Manta-Network/Manta/actions/runs/7262536984 edit: Seems like its Manta run because it tried to benchmark zenlink

No, those weights are generated from my computer.

Yeah, it succeeded, but benchmark machine failed, I asked Ana to check it again, ensure we don't use low performance computer to benchmark our runtime.

@ghzlatarev
Copy link
Contributor

ghzlatarev commented Dec 20, 2023 •
edited

Didn't we update the weights in the last PR ? Or do we need to do it again ? edit: ah you ran it on your own machine.
One of yesterday's runs succeeded though but not sure if its Manta or Calamari https://github.com/Manta-Network/Manta/actions/runs/7262536984 edit: Seems like its Manta run because it tried to benchmark zenlink

No, those weights are generated from my computer.

Yeah, it succeeded, but benchmark machine failed, I asked Ana to check it again, ensure we don't use low performance computer to benchmark our runtime.

Lower's better than higher, but it also didn't benchmark one of the xcm modules for some reason.
edit: Aha i saw the comment about Statemint's weight.

@Dengjianping
[no ci]Fix calamari runtime benchmark
9c8f801 
Signed-off-by: Dengjianping <djptux@gmail.com>
@Dengjianping Dengjianping requested a review from a team as a code owner December 21, 2023 07:20
@ghzlatarev
Copy link
Contributor

I'd just use the newly generated weights, so we can move this along. It's fine if the machine is less beefy compared to before.

@Dengjianping
Update weights, and enable benchmarking pallet-xcm for manta
b4edc95 
Signed-off-by: Dengjianping <djptux@gmail.com>
ghzlatarev
ghzlatarev previously approved these changes Dec 21, 2023
View reviewed changes
@ghzlatarev
Update manta weights
6bcc3a9 
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
ghzlatarev
ghzlatarev previously approved these changes Dec 21, 2023
View reviewed changes
ferrell-code
ferrell-code previously approved these changes Dec 21, 2023
View reviewed changes
@ghzlatarev
Fix weight compilation
b6145f5 
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
@Dengjianping Dengjianping merged commit 5c2d416 into manta Dec 22, 2023
26 of 27 checks passed
@Dengjianping Dengjianping deleted the release-v4.6.0 branch December 22, 2023 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghzlatarev ghzlatarev ghzlatarev approved these changes

@ferrell-code ferrell-code ferrell-code approved these changes

@anaye1997 anaye1997 anaye1997 approved these changes

Assignees
No one assigned
Labels
A-benchmark-checks A-calamari Area: Issues and PRs related to the Calamari Runtime A-integration-test-checks A-manta Area: Issues and PRs related to the Manta Runtime A-runtime Area: Issues and PRs related to Runtimes A-testing Area: Testing-related Issues and PRs A-unit-test-checks C-enhancement Category: An issue proposing an enhancement or a PR with one L-fixed Log: Issues and PRs related to bug fixes L-release Related to a release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Manta 4.6 Release checklist
4 participants
@Dengjianping @ghzlatarev @ferrell-code @anaye1997