Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add manta docker image to publish #1243

Merged
merged 9 commits into from Aug 23, 2023
Merged

Add manta docker image to publish #1243

merged 9 commits into from Aug 23, 2023

Conversation

ferrell-code
Copy link
Contributor

@ferrell-code ferrell-code commented Aug 2, 2023

Description

Publish manta images to docker hub on release relates #1239


Before we can approve this PR for merge, please make sure that all the following items have been checked off:

  • Connected to an issue with discussion and accepted design using zenhub "Connect issue" button below
  • Added one label out of the L- group to this PR
  • Added one or more labels from the A- and C- groups to this PR
  • Explicitly labelled A-calamari and/or A-manta if your changes are meant for/impact either of these (CI depends on it)
  • Re-reviewed Files changed in the Github PR explorer.

Situational Notes:

  • If adding functionality, write unit tests!
  • If importing a new pallet, choose a proper module index for it, and allow it in BaseFilter. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.
  • If needed, update our Javascript/Typescript APIs. These APIs are officially used by exchanges or community developers.
  • If modifying existing runtime storage items, make sure to implement storage migrations for the runtime and test them with try-runtime. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of #[pallet::storage] items to check for any.

Signed-off-by: Charles Ferrell <charlie@manta.network>
@ferrell-code ferrell-code marked this pull request as draft August 2, 2023 21:36
Signed-off-by: Charles Ferrell <charlie@manta.network>
Signed-off-by: Charles Ferrell <charlie@manta.network>
@ferrell-code ferrell-code added A-automation Area: Issues and PRs related to Automation A-ci Area: Continuous Integration C-cleanup Category: Issues documenting cleanup or PRs that clean code up L-fixed Log: Issues and PRs related to bug fixes labels Aug 2, 2023
@ferrell-code ferrell-code marked this pull request as ready for review August 2, 2023 22:08
Signed-off-by: Charles Ferrell <charlie@manta.network>
Signed-off-by: Charles Ferrell <charlie@manta.network>
@github-actions
Copy link

github-actions bot commented Aug 2, 2023

✅ Congestion test: 1-day congestion cost (manta-runtime) is above the target daily congestion cost

@github-actions
Copy link

github-actions bot commented Aug 2, 2023

⚠️ Congestion test: 1-day congestion cost (calamari-runtime) is NOT above the target daily congestion cost

@ferrell-code ferrell-code changed the title docker test Add manta docker image to publish Aug 3, 2023
Apokalip
Apokalip previously approved these changes Aug 7, 2023
@ghzlatarev ghzlatarev self-requested a review August 8, 2023 03:26
@ghzlatarev
Copy link
Contributor

@ferrell-code let's figure out the /latest image before we merge this.

@ferrell-code
Copy link
Contributor Author

@ferrell-code let's figure out the /latest image before we merge this.

It makes the image created by this action the latest tag too. Not fool proof but that is way action works for calamari.

mantanetwork/${{ matrix.runtime.name }}:${{ github.event.release.tag_name }}

@ghzlatarev
Copy link
Contributor

@ferrell-code let's figure out the /latest image before we merge this.

It makes the image created by this action the latest tag too. Not fool proof but that is way action works for calamari.

mantanetwork/${{ matrix.runtime.name }}:${{ github.event.release.tag_name }}

oh yeah makes sense, I suppose can we put the latest in an if statement , so it only happens for the manta run ?

@ferrell-code
Copy link
Contributor Author

@ferrell-code let's figure out the /latest image before we merge this.

It makes the image created by this action the latest tag too. Not fool proof but that is way action works for calamari.

mantanetwork/${{ matrix.runtime.name }}:${{ github.event.release.tag_name }}

oh yeah makes sense, I suppose can we put the latest in an if statement , so it only happens for the manta run ?

It creates separate images for calamari and manta. So there can be two "latest" tags

ghzlatarev
ghzlatarev previously approved these changes Aug 22, 2023
anaye1997
anaye1997 previously approved these changes Aug 22, 2023
Copy link
Contributor

@anaye1997 anaye1997 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
@ghzlatarev ghzlatarev dismissed stale reviews from anaye1997, Apokalip, and themself via 6cf75bd August 23, 2023 02:52
@ghzlatarev ghzlatarev merged commit 473e610 into manta Aug 23, 2023
18 checks passed
@ghzlatarev ghzlatarev deleted the fer-docker-workflow branch August 23, 2023 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-automation Area: Issues and PRs related to Automation A-benchmark-checks A-ci Area: Continuous Integration A-integration-test-checks A-unit-test-checks C-cleanup Category: Issues documenting cleanup or PRs that clean code up L-fixed Log: Issues and PRs related to bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants