comments on a Switch #23006
Open
comments on a Switch #23006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kbrock Having a switch associate to the EMS through a host was the original way all of the switches worked |
Fryguy
reviewed
Apr 26, 2024
|
update:
Thanks. |
|
Checked commit kbrock@a7e5f7a with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint app/models/switch.rb
|
agrare
reviewed
Apr 26, 2024
| @@ -3,6 +3,9 @@ class Switch < ApplicationRecord | |||
| include CustomActionsMixin | |||
| extend TenancyCommonMixin | |||
|
|
|||
| # Note: | |||
| # DistributedVirtualSwitch, PhysicalSwitch references ems through Switch#ems_id | |||
| # HostVirtualSwitch references ems through HostVirtualSwitch | |||
There was a problem hiding this comment.
Suggested change
| # HostVirtualSwitch references ems through HostVirtualSwitch | |
| # HostVirtualSwitch references ems through Host |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Document how a switch relates to an ems
Some models use
ems_id, others useHostVirtualSwitch