Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue where dialog values are not passed consistently #22849

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Fryguy
Copy link
Member

@Fryguy Fryguy commented Jan 23, 2024

This matches the way it's passed for the dynamic_dialog_field_value_processor i.e.

dialog_values = {:dialog => dialog_field.dialog.try(:automate_values_hash)}

@agrare Please review.

@miq-bot
Copy link
Member

miq-bot commented Jan 23, 2024

Checked commit Fryguy@ea0109f with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint
1 file checked, 0 offenses detected
Everything looks fine. 👍

@agrare
Copy link
Member

agrare commented Jan 23, 2024

@Fryguy spec failures look related

@miq-bot miq-bot added the stale label Apr 29, 2024
@miq-bot
Copy link
Member

miq-bot commented Apr 29, 2024

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

@Fryguy
Copy link
Member Author

Fryguy commented May 8, 2024

I see why it's failing, but I'm not sure I understand it - maybe this isn't the right fix :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants