Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Allow PLUGIN_META to be more easily overridden #22818

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kbrock
Copy link
Member

@kbrock kbrock commented Dec 19, 2023

This is more of a discussion point.

Currently, we override branch/tag for each of our production branches. My goal is to be able to not change the Gemfile for our branches.

For individuals, we often need to override the git repo to point to personal branches.

Not sure the best way to implement this with externalizing it into an ENV variable.

...
This is an old local branch. I remember feeling strongly about this before but can't remember the exact reason. Think I was building an appliance or something. I want to make building a personal appliance/containers easier.

Currently, we override branch for each of our production branches.
For individuals, we often need to override the git repo to point to personal branches
@miq-bot
Copy link
Member

miq-bot commented Dec 19, 2023

Some comments on commit kbrock@d01fbef

Gemfile

  • ⚠️ - 19 - Detected puts. Remove all debugging statements.

@miq-bot
Copy link
Member

miq-bot commented Dec 19, 2023

Checked commit kbrock@d01fbef with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint
1 file checked, 1 offense detected

Gemfile

@Fryguy
Copy link
Member

Fryguy commented Dec 19, 2023

I have a bunch of scripts at release time in manageiq-release to ensure these are all updated. This would have to be taken into consideration for this change.

@Fryguy
Copy link
Member

Fryguy commented Dec 19, 2023

What problem are you trying to solve here? It seems like you want to replace the git references by setting a constant?

@miq-bot miq-bot added the stale label Apr 1, 2024
@miq-bot
Copy link
Member

miq-bot commented Apr 1, 2024

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants