[WIP] Allow updating all plugins when building the lockfile

[Fryguy]

The lockfile generator is very conservative and doesn't update the lockfile refs for git repos (i.e. plugins). As such, when gem updates happen in plugins, they aren't automatically pulled into the lockfile. This new option allows me to see which specific plugins are making changes. I can then choose to just update them all, or pick and choose.

@bdunne Please review.

[Fryguy]

I've also considered pushing does that weird repo path scanning logic into Vmdb::Plugins - if that's preferable, let me know. I only didn't do it because I couldn't decide on the key/method name.

────────────────────────────────────────────────────────
modified: lib/tasks/release.rake
────────────────────────────────────────────────────────
@ lib/tasks/release.rake:190 @ namespace :release do
     update_gems = ENV["UPDATE_GEMS"].to_s.split(" ")
     if ENV["UPDATE_PLUGINS"]
       require "vmdb/plugins"
-      update_gems += Vmdb::Plugins.paths.values.map { |p| p.match(%r{/gems/(.+)-\h+$}).captures.first }
+      update_gems += Vmdb::Plugins.repos.values
     end

     root = Pathname.new(__dir__).join("../..")
────────────────────────────────────────────────────────
modified: lib/vmdb/plugins.rb
────────────────────────────────────────────────────────
@ lib/vmdb/plugins.rb:37 @ def details
         hash[engine] = {
           :name    => engine.name,
           :version => version(engine),
-          :path    => engine.root.to_s
+          :path    => engine.root.to_s,
+          :repo    => engine.root.to_s.match(%r{/gems/(.+)-\h+$}).captures.first
         }
       end
     end
@ lib/vmdb/plugins.rb:51 @ def versions
       details.transform_values { |v| v[:version] }
     end

+    def repos
+      details.transform_values { |v| v[:repo] }
+    end
+
     # Ansible content (roles) that come out-of-the-box, for use by both Automate
     #   and ansible-runner
     def ansible_content

[Fryguy]

This regex is checking the on-disk path (e.g. /Users/jfrey/.gem/ruby/3.0.6/bundler/gems/manageiq-providers-workflows-a7c24c7cdd32), then pulling out the gem/repo name (e.g. manageiq-providers-workflows)

I'm not sure if there's a better way? I guess I could also take the engine name and underscorize it, but I think there's some inconsistencies like manageiq-consumption provides ManageIQ::Showback¹ (i.e. "/Users/jfrey/.gem/ruby/3.0.6/bundler/gems/manageiq-consumption-561f74d85a02" -> ManageIQ::Showback::Engine)

Footnotes

1. https://github.com/ManageIQ/manageiq-consumption/tree/561f74d85a026dc82b3b8bfa4a53f25edfc609bb/lib/manageiq ↩

[miq-bot]

Checked commits Fryguy/manageiq@c30ce70~...b58e156 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint
2 files checked, 0 offenses detected
Everything looks fine. 👍

[Fryguy]

Moved to WIP because when you are running from a plug-in the path is your local dev path. Need to handle that case and be more defensive here in general.

[miq-bot]

This pull request is not mergeable. Please rebase and repush.

[miq-bot]

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

[miq-bot]

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).