Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test #3697 #3798

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Test #3697 #3798

wants to merge 1 commit into from

Conversation

asinghvi17
Copy link
Member

Tests #3697 by deploying the docs from a local PR.

* support the loop option in html video output

* add to changelog

* try adding html animation to docs

* Update animation.md

---------

Co-authored-by: Alexander Plavin <alexander@plav.in>
@asinghvi17
Copy link
Member Author

cc @aplavin

@MakieBot
Copy link
Collaborator

MakieBot commented Apr 18, 2024

Compile Times benchmark

Note, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. All benchmark results are based on the mean time and negative percent mean faster than the base branch. Note, that GLMakie + WGLMakie run on an emulated GPU, so the runtime benchmark is much slower. Results are from running:

using_time = @ctime using Backend
# Compile time
create_time = @ctime fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @ctime Makie.colorbuffer(display(fig))
# Runtime
create_time = @benchmark fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @benchmark Makie.colorbuffer(fig)
using create display create display
GLMakie 3.33s (3.31, 3.36) 0.02+- 163.17ms (160.81, 165.28) 1.85+- 465.45ms (459.73, 473.83) 4.60+- 7.26ms (7.18, 7.31) 0.04+- 25.51ms (25.32, 25.86) 0.20+-
master 3.34s (3.28, 3.39) 0.04+- 164.48ms (161.70, 168.10) 2.56+- 467.97ms (463.31, 472.59) 3.51+- 7.30ms (7.13, 7.52) 0.12+- 25.53ms (25.32, 25.71) 0.14+-
evaluation 1.00x invariant, -0.01s (-0.25d, 0.65p, 0.03std) 1.01x invariant, -1.31ms (-0.59d, 0.30p, 2.20std) 1.01x invariant, -2.52ms (-0.62d, 0.27p, 4.05std) 1.01x invariant, -0.04ms (-0.49d, 0.39p, 0.08std) 1.00x invariant, -0.02ms (-0.12d, 0.83p, 0.17std)
CairoMakie 3.05s (3.03, 3.09) 0.02+- 167.14ms (164.74, 170.15) 1.82+- 102.15ms (101.32, 103.78) 1.05+- 7.45ms (7.40, 7.50) 0.04+- 882.60μs (875.98, 888.20) 4.18+-
master 3.03s (3.00, 3.06) 0.02+- 168.50ms (164.28, 174.40) 3.12+- 103.00ms (102.06, 103.68) 0.56+- 7.40ms (7.33, 7.55) 0.07+- 880.46μs (876.02, 885.77) 4.05+-
evaluation 0.99x invariant, 0.02s (0.73d, 0.19p, 0.02std) 1.01x invariant, -1.37ms (-0.53d, 0.34p, 2.47std) 1.01x invariant, -0.85ms (-1.01d, 0.09p, 0.80std) 0.99x invariant, 0.05ms (0.84d, 0.15p, 0.05std) 1.00x invariant, 2.14μs (0.52d, 0.35p, 4.11std)
WGLMakie 3.68s (3.61, 3.77) 0.06+- 231.22ms (165.63, 387.15) 103.24+- 8.71s (8.49, 8.95) 0.16+- 9.48ms (9.17, 10.12) 0.37+- 68.34ms (67.60, 68.95) 0.58+-
master 3.62s (3.58, 3.69) 0.04+- 289.90ms (162.55, 397.06) 110.15+- 8.81s (8.36, 9.19) 0.36+- 9.61ms (9.12, 10.73) 0.54+- 70.70ms (67.98, 83.68) 5.75+-
evaluation 0.98x invariant, 0.06s (1.16d, 0.05p, 0.05std) 1.25x noisy🤷‍♀️, -58.68ms (-0.55d, 0.32p, 106.70std) 1.01x invariant, -0.11s (-0.38d, 0.50p, 0.26std) 1.01x invariant, -0.12ms (-0.26d, 0.63p, 0.45std) 1.03x invariant, -2.36ms (-0.58d, 0.32p, 3.17std)

@@ -28,15 +28,12 @@ nframes = 30
framerate = 30
hue_iterator = range(0, 360, length=nframes)

record(fig, "color_animation.mp4", hue_iterator;
Record(fig, hue_iterator;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case it seems like Franklin isn't displaying the output - that should probably be corrected...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makie.jl/docs/utils.jl

Lines 93 to 99 in f51eb52

sz = size(Makie.parent_scene(__result)) # hide
open(joinpath(@OUTPUT, "$(name)_size.txt"), "w") do io # hide
print(io, sz[1], " ", sz[2]) # hide
end # hide
save(joinpath(@OUTPUT, "$pngfile"), __result; px_per_unit = 2, pt_per_unit = 0.75, $rest_kwargs_str) # hide
$(svg ? "save(joinpath(@OUTPUT, \"$svgfile\"), __result; px_per_unit = 2, pt_per_unit = 0.75, $rest_kwargs_str)" : "") # hide
nothing # hide

needs some kind of dispatch on VideoStream objects, to return gifs...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants