Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add __wgl_session to the WGLMakie ignore set when generating uniforms #3754

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

asinghvi17
Copy link
Member

The inclusion of this attribute caused the Bonito session to be passed as a uniform, causing an error in ShaderAbstractions when it tried to test for isbits code.

Fixes #3751

Type of change

Delete options that do not apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • Added an entry in CHANGELOG.md (for new features and breaking changes)
  • Added or changed relevant sections in the documentation
  • Added unit tests for new algorithms, conversion methods, etc.
  • Added reference image tests for new plotting functions, recipes, visual options, etc.

The inclusion of this attribute caused the Bonito session to be passed as a uniform, causing an error in ShaderAbstractions when it tried to test for `isbits` code.

Fixes #3751
@MakieBot
Copy link
Collaborator

MakieBot commented Mar 31, 2024

Compile Times benchmark

Note, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. All benchmark results are based on the mean time and negative percent mean faster than the base branch. Note, that GLMakie + WGLMakie run on an emulated GPU, so the runtime benchmark is much slower. Results are from running:

using_time = @ctime using Backend
# Compile time
create_time = @ctime fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @ctime Makie.colorbuffer(display(fig))
# Runtime
create_time = @benchmark fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @benchmark Makie.colorbuffer(fig)
using create display create display
GLMakie 3.34s (3.30, 3.42) 0.04+- 165.35ms (162.50, 168.72) 2.28+- 467.27ms (463.51, 474.77) 3.95+- 7.30ms (7.24, 7.37) 0.05+- 25.64ms (25.58, 25.71) 0.05+-
master 3.32s (3.30, 3.35) 0.02+- 165.56ms (163.48, 167.80) 1.53+- 469.87ms (465.79, 473.89) 2.98+- 7.33ms (7.26, 7.40) 0.06+- 25.65ms (25.53, 25.82) 0.11+-
evaluation 0.99x invariant, 0.02s (0.61d, 0.28p, 0.03std) 1.00x invariant, -0.21ms (-0.11d, 0.84p, 1.91std) 1.01x invariant, -2.6ms (-0.75d, 0.19p, 3.46std) 1.00x invariant, -0.03ms (-0.48d, 0.38p, 0.05std) 1.00x invariant, -0.01ms (-0.08d, 0.88p, 0.08std)
CairoMakie 3.29s (3.26, 3.32) 0.02+- 195.56ms (191.00, 199.28) 2.80+- 118.33ms (117.05, 120.60) 1.44+- 8.21ms (7.63, 8.52) 0.32+- 905.40μs (891.33, 922.63) 11.71+-
master 3.24s (3.17, 3.33) 0.06+- 194.19ms (182.62, 203.09) 8.00+- 116.70ms (112.21, 119.71) 2.62+- 8.17ms (7.45, 8.54) 0.35+- 904.74μs (892.78, 918.24) 10.14+-
evaluation 0.99x invariant, 0.05s (1.00d, 0.10p, 0.04std) 0.99x invariant, 1.37ms (0.23d, 0.68p, 5.40std) 0.99x invariant, 1.63ms (0.77d, 0.18p, 2.03std) 0.99x invariant, 0.04ms (0.13d, 0.81p, 0.33std) 1.00x invariant, 0.67μs (0.06d, 0.91p, 10.93std)
WGLMakie 3.69s (3.60, 3.81) 0.09+- 385.83ms (370.19, 410.24) 14.54+- 8.68s (8.48, 8.89) 0.16+- 9.56ms (9.15, 10.70) 0.52+- 69.13ms (67.95, 70.70) 1.14+-
master 3.71s (3.61, 3.86) 0.08+- 353.83ms (170.40, 405.66) 81.50+- 8.92s (8.46, 9.66) 0.40+- 9.49ms (9.21, 9.89) 0.25+- 69.13ms (68.41, 69.89) 0.53+-
evaluation 1.01x invariant, -0.02s (-0.22d, 0.68p, 0.09std) 0.92x noisy🤷‍♀️, 32.0ms (0.55d, 0.34p, 48.02std) 1.03x invariant, -0.24s (-0.80d, 0.17p, 0.28std) 0.99x invariant, 0.07ms (0.16d, 0.77p, 0.39std) 1.00x invariant, -0.0ms (-0.00d, 1.00p, 0.84std)

@SimonDanisch
Copy link
Member

I don't think this is the fix... As far as I can tell, the bug seems to be, that the same plot gets serialized two times on the second display of fig.

@t-bltg t-bltg added the WGLMakie This relates to WGLMakie.jl, the Web-based WebGL backend for Makie. label May 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WGLMakie This relates to WGLMakie.jl, the Web-based WebGL backend for Makie.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WGLMakie error displaying Figure in VSCode inline context
4 participants