If running under VSCode, automatically set resize_to = :body
#3708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This gives a better default experience for users plotting inside of VSCode. It detects the presence of VSCode by looking to see if `VSCodeServer` is in `Base.loaded_modules`, which it should never be unless we're running inside the language server.
|
Good idea, but this will be sadly a global setting, applying to people not using the plot pane and just developing a Bonito App with inlined plots. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gives a better default experience for users plotting inside of VSCode. It detects the presence of VSCode by looking to see if
VSCodeServeris inBase.loaded_modules, which it should never be unless we're running inside the language server.Type of change
Delete options that do not apply: