Move Arc to MakieCore #3668
Open
Move Arc to MakieCore #3668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the actual way forward is going to be reabsorbing MakieCore into Makie, and having people use pkg extensions to extend Makie's functionality. MakieCore was established before pkg extensions existed, and as this PR shows again, it's very subjective where a line between "core" functionality and the rest would even be. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This moves an Arc stub to MakieCore, so it can be used without depending on Makie.jl. Personally I think almost all
recipes defined in Makie.jl should be made available in MakieCore.jl. If there is interest, I will move more recipes over.