add credentials create/update/delete handling for the broker #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swoehrl-mw
requested changes
Apr 25, 2024
There was a problem hiding this comment.
@Torsten105 Looks like you have copied the credential handling methods for topic/queue without properly adapting them for the broker. As it is it will not work.
Comment on lines
+24
to
+26
| # Wait for topic | ||
| topic_namespace = spec["topicRef"].get("namespace", namespace) | ||
| backend, backend_name, broker_name, topic_name, allowed_k8s_namespaces = _wait_for_topic(logger, topic_namespace, spec["topicRef"]["name"], retry) |
There was a problem hiding this comment.
That cannot work, when a broker is created, there is no topic.
Comment on lines
+88
to
+89
| def create_or_update_broker_credentials(self, topic_name, namespace_name, reset_credentials=False): | ||
| return self._create_or_update_broker_credentials(f"{topic_name}-owner", topic_name, namespace_name, [AccessRights.MANAGE, AccessRights.LISTEN, AccessRights.SEND], topic_name, reset_credentials) |
There was a problem hiding this comment.
On the broker level there is no topic_name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.