Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve CI workflow #313

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Improve CI workflow #313

wants to merge 5 commits into from

Conversation

FantasyTeddy
Copy link
Contributor

This is the implementation of the changes discussed in #311:

  • Extracting the cargo fmt and cargo clippy steps into their own jobs.
    • @grtcdr: What do you think? Is this OK, or should we combine the two jobs?
  • Fail clippy on warnings (required some minor code changes).
  • Execute the "Test" and "Doctor" change on all platforms that support it.

Additionally, I removed the strip variable from the matrix, because it was never used.

@FantasyTeddy
Copy link
Contributor Author

The "GNU/Linux x86_64 (x86_64-unknown-linux-gnu)" job seems to fail the "Doctor" stage because of an actual bug in libmacchina: https://github.com/Macchina-CLI/libmacchina/blob/main/src/linux/mod.rs#L831

@FantasyTeddy FantasyTeddy mentioned this pull request May 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@FantasyTeddy