[OpenACC] Add updates to run moist dycore on Derecho #1140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Files in core_atmosphere and core_init_atmosphere such as Fortran source code, .gitignore, LICENSE, or others do not need execute permissions.
These occur in regions that are already commented out. If left in they cause run time errors. e.g. "Null pointer for temprbuffer (mpas_dmpar.F: 8618)"
Improve the use of whitespace for consistency and to help make some blocks more clearly commented out. It can be difficult to tell what is commented out or not when OpenACC directives are mixed in
gdicker1
force-pushed
the
atmosphere/develop-openacc-derecho-1
branch
from
6bc772a
to
f1cfe53
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes allow the OpenACC build on NSF NCAR's Derecho system by adding a new build target
nvhpc-derechoand fixing some bugs. Also addresses some whitespace inconsistencies that may have hidden issues in mpas_dmpar.F.NOTE: these changes have only been tested by building the atmosphere core without physics by commenting out the
PHYSICS=-DDO_PHYSICSline in src/core_atmosphere/Makefile. This is the "moist dycore."