Units of adv_coefs? #1097
Open
Units of adv_coefs? #1097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've been trying to track units through the dynamics procedure in mpas_atm_time_integration and have found it difficult as several of the units for variables in the Registry are set to unitless when they apparently aren't. The units for adv_coefs and adv_coefs_3rd are a great example of ambiguous units, which––assuming that they are unitless––leads to terms in the tend_w calculation that cannot be added owing to differing units. Having dug through the code, it would seem that the units of these terms must be m^3 since they are multiplied by dcEdge**2 and dvEdge in mpas_atm_core.F. However, I am not confident about this, so I've included it as a separate pull request from my other suggested corrections about units.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been trying to track units through the dynamics procedure in mpas_atm_time_integration and have found it difficult as several of the units for variables in the Registry are set to unitless when they apparently aren't.
The units for adv_coefs and adv_coefs_3rd are a great example of ambiguous units, which––assuming that they are unitless––leads to terms in the tend_w calculation that seemingly cannot be added owing to differing units. Having dug through the code, I think that the units of these terms should be m^3 since the coefficient values are multiplied by dcEdge**2 and dvEdge in mpas_atm_core.F. However, I am not confident about this, so I've included it as a separate pull request from my other suggested corrections about units.
As a general issue/request, it would be great if someone more knowledgable than me could check the units for the variables in the Registry files because their ambiguity makes it really hard for members of the community to contribute to the model!