Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vaep): use iloc to select last value in the dataframe #718

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

abhishekvasu94
Copy link

This commit fixes a bug in the scores and concedes functions in vaep, where the intention is to grab the last element in the dataframe and assign that value to the end of the shifted dataframe

@probberechts probberechts added the bug Something isn't working label May 9, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.84%. Comparing base (5f52604) to head (b1bd166).
Report is 62 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #718      +/-   ##
==========================================
+ Coverage   83.24%   83.84%   +0.59%     
==========================================
  Files          48       48              
  Lines        3677     3707      +30     
  Branches      625      629       +4     
==========================================
+ Hits         3061     3108      +47     
+ Misses        507      489      -18     
- Partials      109      110       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants