Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated compute_features, compute_labels & compute_rate to address bug #507 #706

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jonasmeltzer
Copy link

To address the issue of missing data causing errors in the compute_features and compute_labels functions, this pull request introduces additions to help handle such scenarios.

Some of the changes we made include:

  • Adding test cases to reproduce the issue (in the test_vaep file)
  • Updating the compute_features and compute_labels functions by adding try except statements to handle the error
  • Handling the bug scenario downstream in the compute_rate function

Our code passes all initial test cases as well as the additional cases we wrote. Thanks in advance for taking a look, and let us know if you have any questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant