-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more momentum diagnostics #817
Open
owang01
wants to merge
11
commits into
MITgcm:master
Choose a base branch
from
owang01:more_mom_diags
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I did not look into the details, but since
it mind be better to open an issue first on what diagnostics we would like to add and which one we don't necessary need if we know how to compute from other diags. |
Thanks @jm-c for your comment. I will open an issue. |
Wrap code computing momentum tendency diagnostics for bottom and ice-shelf drag within ALLOW_MOM_TEND_EXTRA_DIAGS
jm-c
reviewed
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes does this PR introduce?
New feature to output more momentum diagnostics
What is the current behaviour?
(You can also link to an open issue here)
What is the new behaviour
Added more momentum diagnostics, originally implemented by Helen Pillar @hpillar (and probably @antnguyen13) for checkpoint68d, to further decompose momentum diagnostics of advection, explicit dissipation, and external forcing to different contributions.
Does this PR introduce a breaking change?
No
Other information:
Diagnostics for 3d U/V momentum tendency from bottom drag
UBotDrag
andVBotDrag
, removed in PR #219, are put back.Suggested addition to
tag-index
(To avoid unnecessary merge conflicts, please don't update
tag-index
. One of the admins will do that when merging your pull request.)