Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more momentum diagnostics #817

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Conversation

owang01
Copy link
Collaborator

@owang01 owang01 commented Mar 24, 2024

What changes does this PR introduce?

New feature to output more momentum diagnostics

What is the current behaviour?

(You can also link to an open issue here)

What is the new behaviour

Added more momentum diagnostics, originally implemented by Helen Pillar @hpillar (and probably @antnguyen13) for checkpoint68d, to further decompose momentum diagnostics of advection, explicit dissipation, and external forcing to different contributions.

Does this PR introduce a breaking change?

No

Other information:

Diagnostics for 3d U/V momentum tendency from bottom drag UBotDrag and VBotDrag, removed in PR #219, are put back.

Suggested addition to tag-index

(To avoid unnecessary merge conflicts, please don't update tag-index. One of the admins will do that when merging your pull request.)

@jm-c
Copy link
Member

jm-c commented Mar 25, 2024

I did not look into the details, but since

  1. there are many more diagnostics added here (20 ?) and
  2. some involves adding back diagnostics that have been removed (e.g, in PR Momentum diagnostics and bottom stress #219)
  3. some pieces of code are not very clear to me (3-D diag for wind ? that also include tides ?)

it mind be better to open an issue first on what diagnostics we would like to add and which one we don't necessary need if we know how to compute from other diags.

@owang01
Copy link
Collaborator Author

owang01 commented Mar 25, 2024

Thanks @jm-c for your comment. I will open an issue.

pkg/mom_vecinv/mom_vecinv.F Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants