Fix surface boundary conditions for TEOS-10 #812
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- convert conservative temperature to potential temperature to use as SST, when eosType='TEOS10' - this is a very rough first pitch and needs to be polished and improved for performance especially for the new functions for temperature conversions which are a poorly disguised copy of MOM6.
- some formatting of the new functions (incomplete)
replace functions by subroutine, documenation
- convert conservative temperature to potential temperature to use as SST, when eosType='TEOS10' - this is a very rough first pitch and needs to be polished and improved for performance especially for the new functions for temperature conversions which are a poorly disguised copy of MOM6.
- some formatting of the new functions (incomplete)
replace functions by subroutine, documenation
In the next step, the runtime parameter sstExtrapol will be moved from data.exf to the global paramter list
without properly retiring it from the EXF_NML_01
to make OpenAD happy
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes does this PR introduce?
This a bug fix towards completing the TEOS-10 implementation
What is the current behaviour?
When using TEOS-10 (
'eosType='TEOS10', indata&PARMS01), the variableTHETAis interpreted as conservative temperatures (CT), which introduces a bias at in bulk formulae at the surface. Therefore CT needs to be converted to potential (or at the surface: in-situ) temperature before using it in bulk formulae.What is the new behaviour
add a new field
seaSurfTempthat is computed once to be used in all bulk formulae. Convert this from CT to potential/in-situ temperature if 'eosType='TEOS10'`.Does this PR introduce a breaking change?
TEOS10sstExtrapolfrompkg/exfto the main namelistdata&PARMS01, I doubt that anyone uses this.Other information:
This is a draft to leave room for discussion as I may have missed a few points.
Also, I moved the extrapolation parameter
sstExtrapolfrompkg/exfto the main namelistdata&PARMS01, so that it is available to all code. We might want to discuss a new name for this or find a good way of retiring it from the namelist without changing the name.Suggested addition to
tag-indexT.B.D.