Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small update to matlab/cs_grid/ scripts #792

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Small update to matlab/cs_grid/ scripts #792

wants to merge 13 commits into from

Conversation

jm-c
Copy link
Member

@jm-c jm-c commented Oct 30, 2023 •
edited

What changes does this PR introduce?

Follows changes from PR #729

What is the current behaviour?

  1. calc_vort_cs.m has not been updated as "long vector" convention was put in place (in {PR Update matlab cs grid scripts #729) , so that it does not work anymore with current set of scripts from cs_grid/.
  2. internal description in rotate_uv2uvEN.m has not been updated according to changes in PR Update matlab cs grid scripts #729
  3. plotting scripts grph_CS.m and grph_CSz.m fail when middle of face 1 is not at the origin longitude.

What is the new behaviour

  • fix first 2 issues.
  • improve treatment of "longitude jump" in plotting scripts grph_CS.m and `grph_CSz.m
  • add new case "kad=3" in split_uv_cub.m to get symetric halo regions (overlap size of 1 on all 4 sides) filled up.

Does this PR introduce a breaking change?

no

Other information:

Suggested addition to tag-index

not sure if these small updates deserve to be listed in tag-index

@jm-c
adjusted for "long-vector" convention
5ac7189 
and also to work with input arrays in compact format
@jm-c
update description
806714e
@jm-c
Improve treatment of longitude jump
d31b313 
so that it also works when middle of face 1 is at Date line (+/- 180 E/W)
(e.g., with solid-body.cs-32x32x1/ exp. grid-files).
@jm-c
change to also work with "compact-format" input
ea56da1
@jrscott jrscott self-requested a review November 13, 2023 15:59
@jm-c jm-c mentioned this pull request Nov 16, 2023
Merged
@jm-c
Merge branch 'master' into post_matlab_cs_grid_update
6d3ff80
@jm-c
New option (kad=3) for overlap of 1
a2d3caf 
This new option add 1 row/column on each side and for both U,V components
(fill overlap size of 1, output size: nc+2, nc+2, nz, 6);
Also fix missing re-setting of dims(2) in kad=0 case for 3-D, compact-format input
@jm-c
minor: use recip_Bo instead of rhoConst
3244be7 
This allows to use same code with Z-coordinate, without any effect on
the results here since recip_Bo == rhoConst in this P-coord set-up.
@jm-c
Copy link
Member Author

jm-c commented Jan 16, 2024

I included a minor adjustment to former PR #794, just to make the customized version of ini_psurf.F isomorphic (works for both P-coord and Z-coord), but does not really fit into this "matlab/cs_grid/" set of updates.

@jm-c
fix "option=2" case
ff351ef 
also for this case, add field "depth" to output "G"
and little clean-up (document arg "nyAxix", remove trailing blanks, ...)
@jm-c
fix typo in comments
50dcc21
@jm-c
Merge branch 'master' into post_matlab_cs_grid_update
f4a3293
@jrscott
Copy link
Member

jrscott commented Apr 19, 2024

I included a minor adjustment to former PR #794, just to make the customized version of ini_psurf.F isomorphic (works for both P-coord and Z-coord), but does not really fit into this "matlab/cs_grid/" set of updates.

Clarity point: in the readme here, it doesn't specify if an atmos or ocean setup, as this is basically irrelevant except for the above factor... But regarding the "passive tracer (here salinity)" suggest changing to (here "salinity" despite bouyancyRelation set to 'ATMOSPHERIC'). Also in that readme, typo cd_grid -> cs_grid

@jm-c
Copy link
Member Author

jm-c commented Apr 22, 2024

@jrscott I can make these 2 adjustments to "README.md" in verification/solid-body.cs-32x32x1/ (although this file is not part of the list of updated files in current PR, since there is no real reason to document anything new affecting this exp.).

@jm-c
fix typo
6c4d9d8 
also make lines shorter than 81.c
@jm-c
minor adjusments:
8142812 
- explicitly mention "atmospheric" set-up (with bouyancyRelation setting)
- remove "salinity" (not relevant in "Overview" section); clarify passive
  tracer setting (in "Comments" section).
@jm-c
fix typo
4955607
@jrscott
Copy link
Member

jrscott commented May 17, 2024

@jm-c as per our discussion, I suggest we merge this in present state but document status in #791 of what's remaining on the general wish list wrt these matlab routines and cs/llc grids, so we can both comment further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrscott jrscott jrscott approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jm-c @jrscott