Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ServerShell.php #9581

Draft
wants to merge 1 commit into
base: 2.4
Choose a base branch
from
Draft

Update ServerShell.php #9581

wants to merge 1 commit into from

Conversation

Kagee
Copy link
Contributor

@Kagee Kagee commented Feb 22, 2024

Generic requirements in order to contribute to MISP:

  • One Pull Request per fix/feature/change/...
  • Keep the amount of commits per PR as small as possible: if for any reason, you need to fix your commit after the pull request, please squash the changes in one single commit (or tell us why not)
  • Always make sure it is mergeable in the default branch (as of today 2020-05-05: branch 2.4)
  • Please make sure Travis CI works on this request, or update the test cases if needed
  • Any major changes adding a functionality should be disabled by default in the config

What does it do?

If it fixes an existing issue, please use github syntax: #<IssueID>

Questions

  • Does it require a DB change?
  • Are you using it in production?
  • Does it require a change in the API (PyMISP for example)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant