Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

code cleanup for RL day #162

Open
wants to merge 17 commits into
base: develop
Choose a base branch
from
Open

code cleanup for RL day #162

wants to merge 17 commits into from

Conversation

zmarinho
Copy link
Contributor

remove deprecated code and add solutions and exercises for day 6 into a single file.

@ramon-astudillo
Copy link
Member

@LxMLS/monitors2019 I would like to be sure that you are ok with this changes before accepting

@antoniogois
Copy link
Contributor

I left a couple comments here

@antoniogois
Copy link
Contributor

summary of the comments:

  1. It seems that now it's clear which bit the students have to complete in 6.5, but I think the students' branch still won't have the incomplete version, after the PR is accepted.

  2. I think the mismatch between the pdf (which seems correct) and notebook (which seems wrong) for 6.5 hasn't been addressed yet

@j6mes j6mes mentioned this pull request Jul 17, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zmarinho @ramon-astudillo @antoniogois