Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes import references for run_all_classifiers #155

Open
wants to merge 11 commits into
base: develop
Choose a base branch
from

Conversation

mloning
Copy link

@mloning mloning commented Jul 12, 2019

What does this implement/fix? Explain your changes.
Fixes references for MaxEntBatch and MaxEntOnline. Previously, threw error as classes were not found.

Other comments
I also suggest to clean up the imports using the following code instead of changing the path, happy to make changes to this PR if you like:

from lxmls.classifiers import naive_bayes as nbc
from lxmls.classifiers import perceptron as percc
from lxmls.classifiers import svm as svmc
from lxmls.classifiers import mira as mirac
from lxmls.classifiers import max_ent_batch as mec_batch
from lxmls.classifiers import max_ent_online as mec_online

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants