Minestom Support

[Codestech1]

No description provided.

[Codestech1]

#3519 But with hydrogen's credit

[underscore11code]

I think reposting this comment from @dev-hydrogen is relevant

That also ignores the issue that the way this works is at best untested, and at worst unstable. How i made my fork work, is that it (tries) to sync up permissions between luckperms and minestom when the player join, and then listens to the luckperms api to sync any changes that happen after that. This approach doesnt allow for any nice-to-haves like wildcard support, as that would mean needing to override hasPermission, which currently is not possible on minestom.

Theres a reason i never made a pull request from my fork, I don't trust it enough to be used anywhere other than on my own servers.

[Codestech1]

I think reposting this comment from @dev-hydrogen is relevant

That also ignores the issue that the way this works is at best untested, and at worst unstable. How i made my fork work, is that it (tries) to sync up permissions between luckperms and minestom when the player join, and then listens to the luckperms api to sync any changes that happen after that. This approach doesnt allow for any nice-to-haves like wildcard support, as that would mean needing to override hasPermission, which currently is not possible on minestom.
Theres a reason i never made a pull request from my fork, I don't trust it enough to be used anywhere other than on my own servers.

Ik, but tell it for minestom, currently (if you merge) you can only note users about limitations. If minestom extensiona will add able to override hasPermission - i will do new pr. Lucko should choose: no minestom or minestom with limitations (e.g. no wildcards). Sorry for bad english

[Codestech1]

I have idea for wildcards, but i will do this in other pr (if you merge this).

[Codestech1]

It's ready to use, you don't need wildcards, latest version of minestom has it built in.

[lucko]

I'm still unsure whether this should be part of the original project, but I am definitely against merging it until Minestom sort out their Maven repository situation and/or start creating proper releases.

The Jitpack releases expire after a while and are a source of annoyance in my other projects which support Minestom (e.g. spark)

[Codestech1]

I'm still unsure whether this should be part of the original project, but I am definitely against merging it until Minestom sort out their Maven repository situation and/or start creating proper releases.

The Jitpack releases expire after a while and are a source of annoyance in my other projects which support Minestom (e.g. spark)

Yeah, i agree, they should make their own maven repository.

[xHyroM]

It's ready to use, you don't need wildcards, latest version of minestom has it built in.

I tried this but when someone sets permission from another server it doesn't update permissions in minestom server so i can still use /lp commands

edit: i fixed it by using https://github.com/nindza-pro/LuckPerms/blob/minestom-support/minestom/src/main/java/me/lucko/luckperms/minestom/listener/PlayerNodeChangeListener.java#L65-L72 instead

[Bloeckchengrafik]

It's ready to use, you don't need wildcards, latest version of minestom has it built in.

With those, negated permissions won't work (at least in my testing)

[ajh123]

Well Minestom is now on Maven central, so we no longer need Jitpack. However there is no official extension support in the newest version so https://github.com/hollow-cube/minestom-ce-extensions has to be used.