This repository has been archived by the owner on Jul 17, 2023. It is now read-only.
Fix: performance issue in LiveCharts.Wpf.DefaultLegend #1125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed a performance issue in DefaultLegend. PropertyChanged event for property "Series" was invoked every time, even if no item in the series list has changed. In charts with a huge amount of lines with a lot of data, this will trigger the redrawing of the legend so many times, that it will freeze the whole UI.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed a performance issue in the DefaultLegend. Whenever the setter of the property "Series" was called, the PropertyChanged event was invoked, which leads to a redrawing of the whole legend. In my demo project, I had plotted about 35 different lines in a CartesianChart and updated it every 10ms with multiple sensor data. The redrawing of the legend, whenever a new sensor data item is available, would completely freeze the UI. Applying the fix, legend is still up-to-date and UI won't freeze.
Solves