Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust parent handling in PPT import #2116

Merged
merged 2 commits into from Oct 31, 2022
Merged

Adjust parent handling in PPT import #2116

merged 2 commits into from Oct 31, 2022

Conversation

hjpalpha
Copy link
Collaborator

@hjpalpha hjpalpha commented Oct 20, 2022 •
edited

Summary

Adjust parent handling in PPT import

  • pass self from Module:PrizePool instead of placements and args
  • use the so passed parent (above passed self) in the _emptyPlacement fucntion

Advantages:

How did you test this change?

/dev

@hjpalpha hjpalpha changed the title Update prize_pool.lua Adjust parent handling in PPT import Oct 20, 2022
@hjpalpha hjpalpha marked this pull request as ready for review October 20, 2022 13:23
iMarbot
iMarbot approved these changes Oct 20, 2022
View reviewed changes
Copy link
Collaborator

@iMarbot iMarbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@hjpalpha hjpalpha requested a review from Rathoz October 20, 2022 15:11
@Rathoz Rathoz merged commit 5585094 into main Oct 31, 2022
@Rathoz Rathoz deleted the ppt-import-parent-handling branch October 31, 2022 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rathoz Rathoz Rathoz approved these changes

@iMarbot iMarbot iMarbot approved these changes

Assignees
No one assigned
Labels
c: prize_pool
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hjpalpha @Rathoz @iMarbot