Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QoL] PPT Import: add option to automate "qualifies1=true" #2003

Open
5 tasks
hjpalpha opened this issue Oct 3, 2022 · 0 comments
Open
5 tasks

[QoL] PPT Import: add option to automate "qualifies1=true" #2003

hjpalpha opened this issue Oct 3, 2022 · 0 comments

Comments

@hjpalpha
Copy link
Collaborator

hjpalpha commented Oct 3, 2022

  • need to pass prizepool (as parent) to import
  • need to adjust Import._emptyPlacement to use that instead of the current way of grabbing parent
  • need to add a function that checks if the matchdata qualifies (if in last stage)
  • need to adjust the function that ports the matchdata to entry data to add the qualifies stuff
  • there needs to be an option to disable the qualifies automation (e.g. if there are >1 things that can be qualified to)

would also eliminate the need for adding the first slot in all cases where this first place doesn't have any manual input (prizes etc)
--> super rare cases but could be a nice QoL (quality of life) change, hence not part of MVP (minimum viable product)

originally requested by martin

@hjpalpha hjpalpha changed the title PPT Import: add option to automate "qualifies1=true" [QOL] PPT Import: add option to automate "qualifies1=true" Oct 3, 2022
@hjpalpha hjpalpha changed the title [QOL] PPT Import: add option to automate "qualifies1=true" [QoL] PPT Import: add option to automate "qualifies1=true" Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants