Skip to content
This repository has been archived by the owner on Feb 17, 2021. It is now read-only.

Horizontal window scrolling if needed. #358

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Horizontal window scrolling if needed. #358

wants to merge 5 commits into from

Commits on Jan 29, 2018

  1. Horizontal window scrolling if needed. 

    The code was not taking X position of window and bubble into account to
scroll in horizontal direction. This was causing issues with tour where
the element is not in the view and horizontal scrolling was needed.

Signed-off-by: Avadh Patel <avadh4all@gmail.com>
    @avadhpatel
    avadhpatel committed Jan 29, 2018
    Configuration menu
    Copy the full SHA
    e66912f View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2018

  1. Animate scrolling using D3 if its available 

    This patch is from Payton Quackenbush.

Signed-off-by: Avadh Patel <avadh4all@gmail.com>
    @avadhpatel
    avadhpatel committed Feb 23, 2018
    Configuration menu
    Copy the full SHA
    dab5ead View commit details
    Browse the repository at this point in the history

  2. Added new option 'bubbleInCenter' 

    If its set, it renders the bubble in the center of the window regardless
of the target position. This option can be used to create a bubble with
information about the page and not a specific target element in the
page.

Signed-off-by: Avadh Patel <avadh4all@gmail.com>
    @avadhpatel
    avadhpatel committed Feb 23, 2018
    Configuration menu
    Copy the full SHA
    bc563f5 View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2018

  1. Call error callback when we can't start tour 

    Also added new API function 'clearState' to cleanup cookies stored
by hopscotch.

Signed-off-by: Avadh Patel <avadh4all@gmail.com>
    @avadhpatel
    avadhpatel committed Feb 26, 2018
    Configuration menu
    Copy the full SHA
    5073fc4 View commit details
    Browse the repository at this point in the history

  2. Check step's showCloseButton option on rendering the bubble 

    Signed-off-by: Avadh Patel <avadh4all@gmail.com>
    @avadhpatel
    avadhpatel committed Feb 26, 2018
    Configuration menu
    Copy the full SHA
    cd025c0 View commit details
    Browse the repository at this point in the history