Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profile picture sizes support #581

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

cln-io
Copy link
Contributor

@cln-io cln-io commented Sep 23, 2023

Adds support for user-defined height and width, still defaults to 128px, but users can now pick larger sizes to display if they want.

image

image

… allowing the user to pick the width & height of their page profile image, this allows more customization
@MagicLike MagicLike added the enhancement New feature or request label Sep 24, 2023
@cln-io
Copy link
Contributor Author

cln-io commented Sep 24, 2023

With this (if wanted) users can set up banners (mostly logo's)

Horizontal banner style
image

image

Vertical banner style

image

image

@JulianPrieber JulianPrieber self-assigned this Sep 24, 2023
@JulianPrieber
Copy link
Member

JulianPrieber commented Sep 24, 2023

Let's get v4.2.9 to production before we work on this.

Just as a heads-up, we usually work around adding new database tables. The updater cannot handle this without extra logic.
We tested adding new tables with only some issues, so this could be an option.

We have a dedicated method we can call in the user controller to save and retrieve small values to and from the database. This could also be used here.

See:

https://github.com/LinkStackOrg/LinkStack/blob/main/app/Http/Controllers/UserController.php#L766-L770

https://github.com/LinkStackOrg/LinkStack/blob/main/resources/views/studio/page.blade.php#L271

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs more work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants