Feature/Use cookiecutter organization name throughout project #656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melissafelch
changed the title
melissafelch
commented
Sep 21, 2023
| MODULE_REGEX = r"^[a-z][_a-z]+$" | ||
|
|
||
| module_name = "{{cookiecutter.repo_name}}" | ||
| module_name = "{{ cookiecutter.repo_name }}" |
There was a problem hiding this comment.
weirdly enough, this file ignores the _jinja2_env_vars for strings?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This pull request builds on work started in PR #280 to utilize org_name and other cookiecutter variables throughout the project. Because cookiecutter uses jinja templating to generate its files, we have created a unique string for blocks and variables which allows internal templating to be ignored as files are processed. This allows us to collect and insert information gathered from cookiecutter prompts.
Any point in the PR you think needs extra attention
In order to use this, please be sure to update cookiecutter to at least v 2.3.0. Otherwise, things will break spectacularly!
I initially missed some files involved in migrations because they were omitted from vscode's search function. While I combed for any instances where cookiecutter was used, there is also a possibility that I may have missed perfectly valid jinja inside files which were not templated. I believe I caught them all but a critical eye would be appreciated!
New Features or Fixes
Video of feature working
Screen.Recording.2023-09-21.at.3.39.10.PM.mov