Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/form refactor #631

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

Feature/form refactor #631

wants to merge 8 commits into from

Conversation

alligatortower
Copy link
Contributor

No description provided.

melissafelch
melissafelch requested changes Sep 11, 2023
View reviewed changes
Copy link
Contributor

@melissafelch melissafelch left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking very nice over here! I think a couple of the updated files got missed with the patch - templates/forms/widgets/password.html is looking for incorrect macro names, and /templates/forms/select.jinja appears to be outdated (it's missing some exports referenced in /form-test/). There's a minor issue with password's missing name as well, but so far this looks ✨ great! ✨

@melissafelch melissafelch mentioned this pull request Sep 11, 2023
Open
@alligatortower
Copy link
Contributor Author

Let it be written into record -- my rebasing swallowed some of Melissa's commits and so she deserves some credit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melissafelch melissafelch melissafelch requested changes

@gone gone Awaiting requested review from gone

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alligatortower @melissafelch