Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add parentAccount in getMainAccount #6769

Merged
merged 2 commits into from Apr 29, 2024
Merged

Conversation

lvndry
Copy link
Contributor

@lvndry lvndry commented Apr 26, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

bugfix: Add parentAccount parameter in getMainAccount.

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@lvndry lvndry self-assigned this Apr 26, 2024
@lvndry lvndry requested a review from a team as a code owner April 26, 2024 16:44
Copy link

vercel bot commented Apr 26, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Apr 26, 2024 4:45pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Apr 26, 2024 4:45pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Apr 26, 2024 4:45pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Apr 26, 2024 4:45pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Apr 26, 2024 4:45pm

@live-github-bot live-github-bot bot added the mobile Has changes in LLM label Apr 26, 2024
Copy link
Contributor

@gre gre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(i wonder if there is a way to force the signature to always be used with two params for the getMainAccount, but since the second param can be falsy, this signature is allowed)

@lvndry lvndry merged commit f317536 into develop Apr 29, 2024
36 of 37 checks passed
@lvndry lvndry deleted the bugfix/live-12376-getMainAccount branch April 29, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants