Drop Account#name, Account#starred and LLD to use Currency Settings' instead of Account#unit #6761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 5 Ignored Deployments
|
live-github-bot
bot
added
desktop
gre
force-pushed
the
support/account-name-lldunit
branch
from
5a8ba05
to
03ef4fc
Compare
gre
force-pushed
the
support/account-name-lldunit
branch
from
03ef4fc
to
e5d4d57
Compare
hedi-edelbloute
previously approved these changes
Apr 29, 2024
ofreyssinet-ledger
previously approved these changes
Apr 30, 2024
Justkant
reviewed
Apr 30, 2024
apps/ledger-live-desktop/src/renderer/components/AccountsList/AccountRow.tsx
Show resolved
Hide resolved
Comment on lines
67
to
79
| overflowStyles: React.CSSProperties = { | ||
| const overflowStyles: React.CSSProperties = { | ||
| textOverflow: "ellipsis", | ||
| overflow: "hidden", | ||
| whiteSpace: "nowrap", | ||
| }; |
There was a problem hiding this comment.
This probably should be moved outside the component
.../ledger-live-desktop/src/renderer/families/cardano/DelegationFlowModal/steps/StepSummary.tsx
Show resolved
Hide resolved
.../ledger-live-desktop/src/renderer/families/cardano/UndelegateFlowModal/steps/StepSummary.tsx
Show resolved
Hide resolved
apps/ledger-live-desktop/src/renderer/modals/SettingsAccount/AccountSettingRenderBody.tsx
Show resolved
Hide resolved
gre
dismissed stale reviews from ofreyssinet-ledger, hedi-edelbloute, and CremaFR
via
c0764f2
gre
force-pushed
the
support/account-name-lldunit
branch
from
e5d4d57
to
c0764f2
Compare
Justkant
reviewed
Apr 30, 2024
apps/ledger-live-desktop/src/renderer/screens/accounts/AccountRowItem/index.tsx
Show resolved
Hide resolved
apps/ledger-live-desktop/src/renderer/screens/accounts/AccountRowItem/index.tsx
Show resolved
Hide resolved
apps/ledger-live-desktop/src/renderer/screens/settings/sections/Accounts/CurrencyRows.tsx
Show resolved
Hide resolved
gre
force-pushed
the
support/account-name-lldunit
branch
from
c0764f2
to
74717c4
Compare
Justkant
previously approved these changes
Apr 30, 2024
gre
force-pushed
the
support/account-name-lldunit
branch
from
74717c4
to
e9c8c82
Compare
|
i'm moving this back to Draft because i think we need to ship #6791 with it too, so i think we'll merge the LLM part in this PR too and will need review on the extra parts that it brings there is notably one thing that we must fix globally to restore support of the |
|
the PR is replaced by #6796 |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Checklist
npx changesetwas attached.📝 Description
This PR is a mashup of two PRs:
since these PR modify similar codebase, it will be simpler to get this PR tested and merged that solved all the conflicts.
Builds
❓ Context
🧐 Checklist for the PR Reviewers