[Coin Modularization] Solana #6721

sprohaszka-ledger · 2024-04-22T13:34:52Z

✅ Checklist

npx changeset was attached.
Covered by automatic tests.
Impact of the changes:
- ...

📝 Description

Extract Solana as a module

❓ Context

JIRA or GitHub link: LIVE-8175

🧐 Checklist for the PR Reviewers

The code aligns with the requirements described in the linked JIRA or GitHub issue.
The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
There are no undocumented trade-offs, technical debt, or maintainability issues.
The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
Any new dependencies have been justified and documented.
Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

vercel · 2024-04-22T13:35:01Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Ignored Deployments

Name	Status	Preview	Updated (UTC)
ledger-live-docs	⬜️ Ignored (Inspect)	Visit Preview	May 3, 2024 0:49am
ledger-live-github-bot	⬜️ Ignored (Inspect)	Visit Preview	May 3, 2024 0:49am
native-ui-storybook	⬜️ Ignored (Inspect)	Visit Preview	May 3, 2024 0:49am
react-ui-storybook	⬜️ Ignored (Inspect)	Visit Preview	May 3, 2024 0:49am
web-tools	⬜️ Ignored (Inspect)	Visit Preview	May 3, 2024 0:49am

live-github-bot · 2024-04-22T16:41:03Z

Desktop Bundle Checks

Comparing 0a9f26f against 4d1d7bb.

✅ Previous issues have all been fixed.

Mobile Bundle Checks

Comparing 0a9f26f against 4d1d7bb.

✅ Previous issues have all been fixed.

lvndry · 2024-04-25T08:37:36Z

libs/coin-modules/coin-solana/src/api/chain/index.ts

@@ -16,6 +16,8 @@ import { getEnv } from "@ledgerhq/live-env";
 import { Awaited } from "../../logic";
 import { NetworkError } from "@ledgerhq/errors";

+export const LATEST_BLOCKHASH_MOCK = "EEbZs6DmDyDjucyYbo3LwVJU7pQYuVopYcYTSEZXskW3";


why is it here ? Is it a random hash ?

I don't know its purpose.
I move it for convient reason, as it is used within api calls.

lvndry · 2024-04-25T08:46:13Z

libs/coin-modules/coin-solana/src/logic.ts

This file looks like a "fourre tout". I think we should clearer names and put functions in more specific files.
Maybe helpers/address helpers/token helpers/staking

You're right about staking.
I am adding this file.
But I will not going beyond as we need a better separation about what needs to be imported by the UI what doesn't.

lvndry · 2024-04-25T08:50:11Z

libs/coin-modules/coin-solana/src/types.ts

+  memo?: string;
+};
+
+export type TokenCreateATACommand = {


Maybe types.ts files are also too much like a "fourre tout". I think it could be nice to have things organized by purpose/role.

Like a token.ts with the type, the helper functions, etc

I don't want to refacto this coin-module for the time being.
The only purpose is to separate the code from LLC, as we have done for Algorand, Near and Bitcoin.

libs/ledger-live-common/src/families/solana/bridge/mock.ts

socket-security · 2024-04-29T13:32:24Z

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher

View full report↗︎

gre · 2024-04-30T09:40:32Z

libs/ledger-live-common/src/families/cardano/cli-transaction.ts

@@ -2,7 +2,7 @@ import { Account, AccountLike } from "@ledgerhq/types-live";
 import invariant from "invariant";
 import flatMap from "lodash/flatMap";
 import { getAccountCurrency } from "../../account";
-import { TokenAccount } from "../solana/api/chain/account/token";


Cardano depends on Solana?

It surprised me too.
The fix will be part of Cardano modularization...

gre

lgtm for hub scope.
one possible (historical?) mistake on cardano->solana dep

github-actions · 2024-05-02T14:14:25Z

[Bot] Testing with 'Nitrogen' ($0.00) ⏲ 10min 2s

What is the bot and how does it work? Everything is documented here!

1 critical spec errors

Spec Solana failed!

Error: scan accounts timeout for currency Solana

Details of the 0 mutations

Spec Solana (failed)

Details of the 8 uncovered mutations

Spec Solana (8)

Transfer ~50%:
Transfer Max:
Delegate:
Deactivate Activating Delegation:
Deactivate Active Delegation:
Reactivate Deactivating Delegation:
Activate Inactive Delegation:
Withdraw Delegation:

Portfolio ($0.00) – Details of the 1 currencies

Spec (accounts)	State	Remaining Runs (est)	funds?
Solana (0)	0 ops , 🤷‍♂️	❌	``

Performance ⏲ 10min 2s

Time spent for each spec: (total across mutations)

Spec (accounts)	preload	scan	re-sync	tx status	sign op	broadcast	test	destination test
TOTAL	150ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A
Solana (0)	150ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A

What is the bot and how does it work? Everything is documented here!

Signed-off-by: Stéphane Prohaszka <stephane.prohaszka@ledger.fr>

github-actions bot assigned sprohaszka-ledger Apr 22, 2024

live-github-bot bot added the common Has changes in live-common label Apr 22, 2024

vercel bot had a problem deploying to Preview – web-tools April 22, 2024 13:40 Failure

vercel bot deployed to Preview – web-tools April 22, 2024 14:59 View deployment

vercel bot deployed to Preview – web-tools April 22, 2024 15:20 View deployment

sprohaszka-ledger force-pushed the feat/LIVE-8175-solana branch from 30e67d3 to 0f75dee Compare April 22, 2024 15:24

vercel bot deployed to Preview – web-tools April 22, 2024 15:28 View deployment

live-github-bot bot added desktop Has changes in LLD mobile Has changes in LLM labels Apr 22, 2024

vercel bot deployed to Preview – web-tools April 22, 2024 16:11 View deployment

sprohaszka-ledger force-pushed the feat/LIVE-8175-solana branch from c3c09eb to a82fe74 Compare April 22, 2024 16:21

vercel bot had a problem deploying to Preview – web-tools April 22, 2024 16:22 Failure

vercel bot deployed to Preview – web-tools April 22, 2024 16:52 View deployment

vercel bot deployed to Preview – web-tools April 22, 2024 17:02 View deployment

vercel bot deployed to Preview – web-tools April 23, 2024 11:33 View deployment

sprohaszka-ledger marked this pull request as ready for review April 23, 2024 11:52

sprohaszka-ledger requested review from a team as code owners April 23, 2024 11:52

sprohaszka-ledger force-pushed the feat/LIVE-8175-solana branch from 7ab805a to f7ee709 Compare April 23, 2024 12:32

vercel bot deployed to Preview – web-tools April 23, 2024 12:39 View deployment

lvndry reviewed Apr 25, 2024

View reviewed changes

sprohaszka-ledger requested a review from lvndry April 25, 2024 14:20

sprohaszka-ledger changed the title ~~Solana modularization~~ [Coin Modularization] Solana Apr 26, 2024

hedi-edelbloute previously approved these changes Apr 29, 2024

View reviewed changes

sprohaszka-ledger dismissed hedi-edelbloute’s stale review via 998f100 April 29, 2024 08:25

sprohaszka-ledger force-pushed the feat/LIVE-8175-solana branch from 01a145a to 998f100 Compare April 29, 2024 08:25

vercel bot deployed to Preview – web-tools April 29, 2024 08:32 View deployment

sprohaszka-ledger force-pushed the feat/LIVE-8175-solana branch from 998f100 to 4ef7359 Compare April 29, 2024 13:30

sprohaszka-ledger force-pushed the feat/LIVE-8175-solana branch from 4ef7359 to b31063e Compare April 29, 2024 13:30

vercel bot had a problem deploying to Preview – web-tools April 29, 2024 13:37 Failure

hedi-edelbloute previously approved these changes Apr 29, 2024

View reviewed changes

gre reviewed Apr 30, 2024

View reviewed changes

gre previously approved these changes Apr 30, 2024

View reviewed changes

sprohaszka-ledger added 13 commits May 3, 2024 13:53

chore: work in progress

b6c3d43

Signed-off-by: Stéphane Prohaszka <stephane.prohaszka@ledger.fr>

fix: compile issue

88a913e

Signed-off-by: Stéphane Prohaszka <stephane.prohaszka@ledger.fr>

fix: add solana to common test

53c08b5

Signed-off-by: Stéphane Prohaszka <stephane.prohaszka@ledger.fr>

fix: lint

704ae3d

Signed-off-by: Stéphane Prohaszka <stephane.prohaszka@ledger.fr>

fix: mobile and desktop solana import

65d8ec4

Signed-off-by: Stéphane Prohaszka <stephane.prohaszka@ledger.fr>

fix: unimported

a394c52

Signed-off-by: Stéphane Prohaszka <stephane.prohaszka@ledger.fr>

fix: remove unused import

7e73bb9

Signed-off-by: Stéphane Prohaszka <stephane.prohaszka@ledger.fr>

fix: unimported

3fb1b10

Signed-off-by: Stéphane Prohaszka <stephane.prohaszka@ledger.fr>

chore: feedbacks

3660a07

Signed-off-by: Stéphane Prohaszka <stephane.prohaszka@ledger.fr>

chore: changeset

0d1e9d6

Signed-off-by: Stéphane Prohaszka <stephane.prohaszka@ledger.fr>

fix: add missing integration test snapshot

29d3e40

Signed-off-by: Stéphane Prohaszka <stephane.prohaszka@ledger.fr>

fix: pnpm-lock from develop

daef00b

Signed-off-by: Stéphane Prohaszka <stephane.prohaszka@ledger.fr>

chore: update pnpm-lock after rebase

0a9f26f

Signed-off-by: Stéphane Prohaszka <stephane.prohaszka@ledger.fr>

sprohaszka-ledger dismissed stale reviews from gre and hedi-edelbloute via 0a9f26f May 3, 2024 12:48

sprohaszka-ledger force-pushed the feat/LIVE-8175-solana branch from 676a18f to 0a9f26f Compare May 3, 2024 12:48

hedi-edelbloute approved these changes May 3, 2024

View reviewed changes

sprohaszka-ledger merged commit 1cee8ff into develop May 3, 2024
58 checks passed

sprohaszka-ledger deleted the feat/LIVE-8175-solana branch May 3, 2024 14:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Coin Modularization] Solana #6721

[Coin Modularization] Solana #6721

sprohaszka-ledger commented Apr 22, 2024 •

edited by jira bot

vercel bot commented Apr 22, 2024 •

edited

live-github-bot bot commented Apr 22, 2024 •

edited

lvndry Apr 25, 2024

sprohaszka-ledger Apr 25, 2024

lvndry Apr 25, 2024

sprohaszka-ledger Apr 25, 2024

lvndry Apr 25, 2024

sprohaszka-ledger Apr 25, 2024

socket-security bot commented Apr 29, 2024 •

edited

gre Apr 30, 2024 •

edited

sprohaszka-ledger Apr 30, 2024

gre left a comment

github-actions bot commented May 2, 2024

Spec Solana (failed)

Spec Solana (8)

[Coin Modularization] Solana #6721

[Coin Modularization] Solana #6721

Conversation

sprohaszka-ledger commented Apr 22, 2024 • edited by jira bot

✅ Checklist

📝 Description

❓ Context

🧐 Checklist for the PR Reviewers

vercel bot commented Apr 22, 2024 • edited

live-github-bot bot commented Apr 22, 2024 • edited

Desktop Bundle Checks

Mobile Bundle Checks

lvndry Apr 25, 2024

Choose a reason for hiding this comment

sprohaszka-ledger Apr 25, 2024

Choose a reason for hiding this comment

lvndry Apr 25, 2024

Choose a reason for hiding this comment

sprohaszka-ledger Apr 25, 2024

Choose a reason for hiding this comment

lvndry Apr 25, 2024

Choose a reason for hiding this comment

sprohaszka-ledger Apr 25, 2024

Choose a reason for hiding this comment

socket-security bot commented Apr 29, 2024 • edited

gre Apr 30, 2024 • edited

Choose a reason for hiding this comment

sprohaszka-ledger Apr 30, 2024

Choose a reason for hiding this comment

gre left a comment

Choose a reason for hiding this comment

github-actions bot commented May 2, 2024

[Bot] Testing with 'Nitrogen' ($0.00) ⏲ 10min 2s

Spec Solana (failed)

Spec Solana (8)

sprohaszka-ledger commented Apr 22, 2024 •

edited by jira bot

vercel bot commented Apr 22, 2024 •

edited

live-github-bot bot commented Apr 22, 2024 •

edited

socket-security bot commented Apr 29, 2024 •

edited

gre Apr 30, 2024 •

edited