feat: Save locally added manifest into the storage on both Mobile and Desktop client #6719

RamyEB · 2024-04-22T09:21:12Z

✅ Checklist

npx changeset was attached.
Covered by automatic tests.
Impact of the changes:
- ...

📝 Description

Save locally added manifest into the storage on both Mobile and Desktop client

❓ Context

JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

The code aligns with the requirements described in the linked JIRA or GitHub issue.
The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
There are no undocumented trade-offs, technical debt, or maintainability issues.
The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
Any new dependencies have been justified and documented.
Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

vercel · 2024-04-22T09:21:21Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Ignored Deployments

Name	Status	Preview	Updated (UTC)
ledger-live-docs	⬜️ Ignored (Inspect)	Visit Preview	May 7, 2024 1:36pm
ledger-live-github-bot	⬜️ Ignored (Inspect)	Visit Preview	May 7, 2024 1:36pm
native-ui-storybook	⬜️ Ignored (Inspect)	Visit Preview	May 7, 2024 1:36pm
react-ui-storybook	⬜️ Ignored (Inspect)	Visit Preview	May 7, 2024 1:36pm
web-tools	⬜️ Ignored (Inspect)	Visit Preview	May 7, 2024 1:36pm

Justkant

LGTM just some small comments

Justkant · 2024-05-03T07:42:32Z

apps/ledger-live-desktop/src/renderer/components/PlatformAppProviderWrapper.tsx

@@ -33,11 +38,17 @@ export function PlatformAppProviderWrapper({ children }: PlatformAppProviderWrap
      }}
      updateFrequency={AUTO_UPDATE_DEFAULT_DELAY}
    >
-      <LocalLiveAppProvider>
+      <LocalLiveAppProvider db={useLocalLiveAppDB()}>


We should probably call the hook outside JSX and create a constant db above

Justkant · 2024-05-03T07:46:03Z

apps/ledger-live-desktop/src/renderer/screens/settings/sections/Developer/RunLocalAppButton.tsx

+  console.log("state localLiveApps", localLiveApps);
+


We should probably remove this console.log

Justkant · 2024-05-03T07:46:38Z

apps/ledger-live-mobile/src/PlatformAppProviderWrapper.tsx

@@ -32,11 +38,19 @@ export default function PlatformAppProviderWrapper({ children }: PlatformAppProv
        lang,
      }}
    >
-      <LocalLiveAppProvider>
+      <LocalLiveAppProvider db={useLocalLiveAppDB()}>


We should probably move this hook too outside the jsx

lambertkevin

LGTM for the coin integration scope

LucasWerey · 2024-05-07T11:06:31Z

apps/ledger-live-mobile/src/screens/Settings/Developer/CustomManifest.tsx

+          {list.map(m => {
+            return (
+              // eslint-disable-next-line react/jsx-key
+              <Box flexDirection="row">


Can't we use m.id as key to avoid // eslint-disable-next-line react/jsx-key ?

apps/ledger-live-mobile/src/screens/Platform/v2/Catalog/LocalLiveApp.tsx

…anifest page

github-actions bot assigned RamyEB Apr 22, 2024

live-github-bot bot added desktop Has changes in LLD common Has changes in live-common labels Apr 22, 2024

RamyEB force-pushed the feat/LIVE-11397-save-locally-loaded-apps branch from 9a0af59 to da09c01 Compare April 22, 2024 15:41

live-github-bot bot added the translations Translation files have been touched label Apr 22, 2024

vercel bot deployed to Preview – web-tools April 22, 2024 15:46 View deployment

RamyEB force-pushed the feat/LIVE-11397-save-locally-loaded-apps branch from 1b02751 to a5caa86 Compare April 23, 2024 12:43

live-github-bot bot added mobile Has changes in LLM ledgerjs Has changes in the ledgerjs open source libs tools Has changes in tools automation CI/CD stuff labels Apr 26, 2024

RamyEB force-pushed the feat/LIVE-11397-save-locally-loaded-apps branch from 068f43d to 0a3dcf3 Compare April 26, 2024 15:05

live-github-bot bot removed ledgerjs Has changes in the ledgerjs open source libs tools Has changes in tools automation CI/CD stuff labels Apr 26, 2024

vercel bot deployed to Preview – web-tools April 26, 2024 16:29 View deployment

RamyEB force-pushed the feat/LIVE-11397-save-locally-loaded-apps branch from 9803689 to a5bf6e7 Compare April 30, 2024 14:22

RamyEB marked this pull request as ready for review April 30, 2024 14:22

RamyEB requested review from a team as code owners April 30, 2024 14:22

RamyEB changed the title ~~feat: create useLocalLiveApp hook~~ feat: Save locally added manifest into the storage on both Mobile and Desktop client Apr 30, 2024

vercel bot deployed to Preview – web-tools April 30, 2024 14:50 View deployment

RamyEB force-pushed the feat/LIVE-11397-save-locally-loaded-apps branch from 1ccea88 to e9d5fb6 Compare May 2, 2024 10:35

vercel bot deployed to Preview – web-tools May 2, 2024 10:40 View deployment

vercel bot deployed to Preview – web-tools May 2, 2024 13:40 View deployment

Justkant reviewed May 3, 2024

View reviewed changes

lambertkevin previously approved these changes May 7, 2024

View reviewed changes

LucasWerey reviewed May 7, 2024

View reviewed changes

LucasWerey previously approved these changes May 7, 2024

View reviewed changes

LucasWerey reviewed May 7, 2024

View reviewed changes

apps/ledger-live-mobile/src/screens/Platform/v2/Catalog/LocalLiveApp.tsx Show resolved Hide resolved

kallen-ledger previously approved these changes May 7, 2024

View reviewed changes

RamyEB added 15 commits May 7, 2024 14:44

feat: create useLocalLiveApp hook

a977310

feat: add local db live apps to discover

f794326

fix: repare removeManifestById

1d1b018

feat: display locally loaded app on mobile

0cbb518

feat: llc combine hook and context

2618ce3

feat: replace hook by context on lld

eb97771

feat: implement context with hook in mobile and rework import local m…

2719556

…anifest page

fix: fix and changeset

8c88714

fix: merge

62614e5

fix: test

cf9a0a4

fix: remove useless useManifest

32d3dce

fix: small fix errors

4cf2fb5

fix: remove context from jsx

cb6a7fa

fix: prevent from undefined key

bffdc71

fix: add index to path

69aa79f

RamyEB dismissed stale reviews from kallen-ledger, LucasWerey, lambertkevin, and Justkant via 69aa79f May 7, 2024 12:47

RamyEB force-pushed the feat/LIVE-11397-save-locally-loaded-apps branch from 45fc8b9 to 69aa79f Compare May 7, 2024 12:47

Justkant previously approved these changes May 7, 2024

View reviewed changes

fix: add react key

a5716d7

RamyEB dismissed Justkant’s stale review via a5716d7 May 7, 2024 13:36

Justkant approved these changes May 7, 2024

View reviewed changes

kallen-ledger approved these changes May 7, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Save locally added manifest into the storage on both Mobile and Desktop client #6719

feat: Save locally added manifest into the storage on both Mobile and Desktop client #6719

RamyEB commented Apr 22, 2024 •

edited

vercel bot commented Apr 22, 2024 •

edited

Justkant left a comment

Justkant May 3, 2024

Justkant May 3, 2024

Justkant May 3, 2024

lambertkevin left a comment

LucasWerey May 7, 2024

feat: Save locally added manifest into the storage on both Mobile and Desktop client #6719

Are you sure you want to change the base?

feat: Save locally added manifest into the storage on both Mobile and Desktop client #6719

Conversation

RamyEB commented Apr 22, 2024 • edited

✅ Checklist

📝 Description

❓ Context

🧐 Checklist for the PR Reviewers

vercel bot commented Apr 22, 2024 • edited

Justkant left a comment

Choose a reason for hiding this comment

Justkant May 3, 2024

Choose a reason for hiding this comment

Justkant May 3, 2024

Choose a reason for hiding this comment

Justkant May 3, 2024

Choose a reason for hiding this comment

lambertkevin left a comment

Choose a reason for hiding this comment

LucasWerey May 7, 2024

Choose a reason for hiding this comment

RamyEB commented Apr 22, 2024 •

edited

vercel bot commented Apr 22, 2024 •

edited