Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support/b2CQA playwright x speculos V1 #6680

Open
wants to merge 42 commits into
base: qaa
Choose a base branch
from
Open

Support/b2CQA playwright x speculos V1 #6680

wants to merge 42 commits into from

Conversation

valber-ledger
Copy link
Contributor

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

V1 for Speculos x Playwright tests.
Test implemented: addAccount, Receive, Send, ERC20 token
How to run the test:

  • Start Speculos on a docker container (cf doc Speculos)
  • Run Speculos Test: pnpm desktop test:playwright specs/speculos/

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@vercel Vercel
Copy link

vercel bot commented Apr 16, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview May 6, 2024 3:42pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview May 6, 2024 3:42pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview May 6, 2024 3:42pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview May 6, 2024 3:42pm
web-tools ⬜️ Ignored (Inspect) Visit Preview May 6, 2024 3:42pm

@live-github-bot live-github-bot bot added the desktop Has changes in LLD label Apr 16, 2024
@valber-ledger valber-ledger force-pushed the support/B2CQA-playwright-x-speculos branch from 2bbd1ea to 4c133a8 Compare April 16, 2024 11:18
@ledger-wiz-cspm-secret-detection
Copy link

Wiz Scan Summary
IaC Misconfigurations 0C 0H 0M 0L 0I
Sensitive Data 0C 0H 0M 0L 92I
Total 0C 0H 0M 0L 92I
Secrets 0🔑

ypolishchuk-ledger
ypolishchuk-ledger reviewed Apr 16, 2024
View reviewed changes
apps/ledger-live-desktop/src/renderer/screens/account/AccountActionsDefault.tsx Outdated Show resolved Hide resolved
apps/ledger-live-desktop/src/renderer/components/debug/DebugSpeculos.tsx Outdated Show resolved Hide resolved
apps/ledger-live-desktop/tests/models/SpeculosModal.ts Outdated Show resolved Hide resolved
apps/ledger-live-desktop/tests/playwright.config.ts Outdated Show resolved Hide resolved
apps/ledger-live-desktop/tests/specs/accounts/delegate.smoke.spec.ts Outdated Show resolved Hide resolved
apps/ledger-live-desktop/tests/specs/speculos/receiveSpeculos.spec.ts Outdated Show resolved Hide resolved
apps/ledger-live-desktop/tests/specs/speculos/receiveSpeculos.spec.ts Outdated Show resolved Hide resolved
apps/ledger-live-desktop/tests/specs/speculos/receiveSpeculos.spec.ts Outdated Show resolved Hide resolved
apps/ledger-live-desktop/tests/specs/speculos/sendSpeculos.spec.ts Outdated Show resolved Hide resolved
apps/ledger-live-desktop/tests/specs/speculos/tokenSpeculos.spec.ts Outdated Show resolved Hide resolved
@valber-ledger valber-ledger force-pushed the support/B2CQA-playwright-x-speculos branch 3 times, most recently from d012790 to 1b2b289 Compare April 16, 2024 15:54
@valber-ledger valber-ledger changed the title Support/b2 cqa playwright x speculos V1 Support/b2CQA playwright x speculos V1 Apr 16, 2024
@valber-ledger valber-ledger force-pushed the support/B2CQA-playwright-x-speculos branch 2 times, most recently from b7b84c0 to 4611674 Compare April 17, 2024 08:36
@live-github-bot live-github-bot bot added the common Has changes in live-common label Apr 18, 2024
@valber-ledger valber-ledger force-pushed the support/B2CQA-playwright-x-speculos branch from 3117c9d to e013b14 Compare April 18, 2024 15:01
@live-github-bot live-github-bot bot added mobile Has changes in LLM ledgerjs Has changes in the ledgerjs open source libs translations Translation files have been touched labels Apr 18, 2024
@socket-security Socket Security
Copy link

socket-security bot commented Apr 18, 2024 •
edited

No dependency changes detected. Learn more about Socket for GitHub ↗︎

👍 No dependency changes detected in pull request

@valber-ledger valber-ledger removed mobile Has changes in LLM common Has changes in live-common ledgerjs Has changes in the ledgerjs open source libs labels Apr 19, 2024
abdurrahman-ledger and others added 19 commits May 6, 2024 14:08
@abdurrahman-ledger @valber-ledger
ci: fix speculos on the fly API port generation
8cc2b27
@abdurrahman-ledger @valber-ledger
test: fix speculos stop during tests
7251f09
@abdurrahman-ledger @valber-ledger
test: fix typing
e9a35c5
@abdurrahman-ledger @valber-ledger
test: fix speculos API port in tests
c11d620
@abdurrahman-ledger @valber-ledger
test: create different project for Speculos tests
8c1c464
@abdurrahman-ledger @valber-ledger
ci: fix using speculos project on e2e tests
100f22f
@abdurrahman-ledger @valber-ledger
ci: fix inverted filter
da0e59b
@abdurrahman-ledger @valber-ledger
test: fix screenshot path after creating different project for Specul…
4b02373 
…os tests
@valber-ledger
speculos update test: remove of screenshots
866169f
@abdurrahman-ledger @valber-ledger
test: tweak playwright environments to fix mocked tests
dfc04f3
@valber-ledger
test: update TokenSpeculos
d31ae8c
@valber-ledger
fix: update enums + update account and Receive test + update userdata
6d3f806
@valber-ledger
fix: update of SendApprove test and modals
e22e358
@valber-ledger
fix: remove coms
ed93fda
@valber-ledger
fix: sendApprove for tBTC
c626609
@valber-ledger
feat: new/update enums (Currency, Account, Transaction, DeviceLabel) …
4557d5d 
…+ wait for fonction
@valber-ledger
fix: update of receiveSpeculos and sendApproveSpeculos
8c8ca00
@valber-ledger
feat: ADA added to accountSpeculos test + updates
f268c38
@valber-ledger
fix: update method for address checking in receiveSpeculos
57afd31
@valber-ledger valber-ledger force-pushed the support/B2CQA-playwright-x-speculos branch from 8b9b7de to 57afd31 Compare May 6, 2024 12:08
@live-github-bot live-github-bot bot removed mobile Has changes in LLM ledgerjs Has changes in the ledgerjs open source libs tools Has changes in tools cli labels May 6, 2024
@valber-ledger valber-ledger marked this pull request as ready for review May 7, 2024 07:37
@valber-ledger valber-ledger requested review from a team as code owners May 7, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ypolishchuk-ledger ypolishchuk-ledger ypolishchuk-ledger left review comments

@bharamboure-ledger bharamboure-ledger bharamboure-ledger left review comments

@abdurrahman-ledger abdurrahman-ledger Awaiting requested review from abdurrahman-ledger

Assignees

@valber-ledger valber-ledger

Labels
automation CI/CD stuff common Has changes in live-common desktop Has changes in LLD
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@valber-ledger @ypolishchuk-ledger @bharamboure-ledger @abdurrahman-ledger