Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[B2CQA-2267] Detox iOS WebView testing #6666

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

[B2CQA-2267] Detox iOS WebView testing #6666

wants to merge 3 commits into from
+25 −37

Conversation

abdurrahman-ledger
Copy link
Contributor

@abdurrahman-ledger abdurrahman-ledger commented Apr 12, 2024 •
edited by jira bot

✅ Checklist

  • npx changeset was attached. (No need)
  • Covered by automatic tests.
  • Impact of the changes:
    • Detox E2E tests

📝 Description

Updating Detox to latest version to enable iOS WebView testing

❓ Context

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@vercel Vercel
Copy link

vercel bot commented Apr 12, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview May 7, 2024 0:56am
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview May 7, 2024 0:56am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview May 7, 2024 0:56am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview May 7, 2024 0:56am
web-tools ⬜️ Ignored (Inspect) Visit Preview May 7, 2024 0:56am

@live-github-bot live-github-bot bot added the mobile Has changes in LLM label Apr 12, 2024
@abdurrahman-ledger abdurrahman-ledger marked this pull request as ready for review April 15, 2024 07:29
@abdurrahman-ledger abdurrahman-ledger requested review from a team as code owners April 15, 2024 07:29
@socket-security Socket Security
Copy link

socket-security bot commented Apr 15, 2024 •
edited

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/detox@20.20.2 environment, eval, filesystem, network, shell, unsafe +93 13.1 MB wix.mobile

🚮 Removed packages: npm/detox@20.18.4

View full report↗︎

@abdurrahman-ledger abdurrahman-ledger force-pushed the support/B2CQA_2267_Detox_iOS_WebView_tests branch from f662c73 to 9aaa215 Compare April 15, 2024 07:43
@abdurrahman-ledger
Copy link
Contributor Author

abdurrahman-ledger commented Apr 15, 2024 •
edited by live-github-bot bot

@abdurrahman-ledger

Generating screenshots: workflow ended

Jobs status:
❌ - generate-screenshots-linux

@live-github-bot live-github-bot bot added desktop Has changes in LLD screenshots Screenshots have been updated labels Apr 15, 2024
@abdurrahman-ledger abdurrahman-ledger force-pushed the support/B2CQA_2267_Detox_iOS_WebView_tests branch from c793c35 to ac1280d Compare April 16, 2024 12:19
@live-github-bot live-github-bot bot removed desktop Has changes in LLD screenshots Screenshots have been updated labels Apr 16, 2024
@abdurrahman-ledger abdurrahman-ledger force-pushed the support/B2CQA_2267_Detox_iOS_WebView_tests branch from 4662a46 to 0f5dc2a Compare May 7, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bharamboure-ledger bharamboure-ledger bharamboure-ledger approved these changes

@ypolishchuk-ledger ypolishchuk-ledger ypolishchuk-ledger left review comments

@mcoursier-ledger mcoursier-ledger mcoursier-ledger left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@abdurrahman-ledger abdurrahman-ledger

Labels
mobile Has changes in LLM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@abdurrahman-ledger @ypolishchuk-ledger @mcoursier-ledger @bharamboure-ledger