Move transaction serialization in correct directory #6663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 5 Ignored Deployments
|
lvndry
reviewed
Apr 17, 2024
| @@ -71,10 +61,18 @@ | |||
| "require": "./lib/nft/*.js", | |||
| "default": "./lib-es/nft/*.js" | |||
| }, | |||
| "./serialization": { | |||
| "require": "./lib/serialization/index.js", | |||
There was a problem hiding this comment.
Never understood why it was required to have a lib and lib-es do know why ? It feels like it's more complicated than it should be
There was a problem hiding this comment.
It depends if you need commonjs or esm module.
lvndry
previously approved these changes
Apr 23, 2024
Signed-off-by: Stéphane Prohaszka <stephane.prohaszka@ledger.fr>
Signed-off-by: Stéphane Prohaszka <stephane.prohaszka@ledger.fr>
Signed-off-by: Stéphane Prohaszka <stephane.prohaszka@ledger.fr>
sprohaszka-ledger
force-pushed
the
support/coin-fmk-serialization
branch
from
0253382
to
5943437
Compare
Signed-off-by: Stéphane Prohaszka <stephane.prohaszka@ledger.fr>
hedi-edelbloute
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Checklist
npx changesetwas attached.📝 Description
Set together all CoinFmk serialization functions.
Create a dedicated "formatters" file.
❓ Context
🧐 Checklist for the PR Reviewers