Merge branch 'release'

.eslintrc.js

@@ -17,6 +17,14 @@ module.exports = {
     "no-inner-declarations": "off",
     // Enables no-unused-vars only from TypeScript
     "no-unused-vars": "off",
+    "no-restricted-imports": [
+      2,
+      {
+        paths: [
+          "lodash", // you must use the lodash/fp module import style to avoid importing the entire library
+        ],
+      },
+    ],
     "@typescript-eslint/no-unused-vars": [
       "error",
       {

.github/pull_request_template.md

@@ -27,7 +27,7 @@ Pull Requests must pass the CI and be code reviewed. Set as Draft if the PR is n
 - [ ] `npx changeset` was attached.
 - [ ] **Covered by automatic tests.** <!-- if not, please explain. (Feature must be tested / Bugfix must bring non-regression) -->
 - [ ] **Impact of the changes:** <!-- Please take some time to list the impact & what specific areas Quality Assurance (QA) should focus on -->
-  - 
+  - ...
 
 ---
 

.github/workflows/build-desktop-external.yml

@@ -76,7 +76,7 @@ jobs:
       - name: Save result
         id: save-result
         shell: bash
-        if: always()
+        if: ${{ !cancelled() }}
         run: |
           echo "${{matrix.os}}=${{steps.build-app.outcome}}" >> $GITHUB_OUTPUT
       - name: Upload linux app
@@ -101,7 +101,7 @@ jobs:
   report:
     needs: build-desktop-app
     runs-on: ubuntu-latest
-    if: always() && !cancelled() && github.event_name == 'workflow_dispatch'
+    if: ${{ !cancelled() && github.event_name == 'workflow_dispatch' }}
     steps:
       - uses: actions/github-script@v6
         name: Get statuses of runs

.github/workflows/build-desktop.yml

@@ -95,21 +95,21 @@ jobs:
 
       - name: Upload bundle metafiles
         uses: actions/upload-artifact@v3
-        if: always()
+        if: ${{ !cancelled() }}
         with:
           name: ${{ matrix.config.name }}-js-bundle-metafiles
           path: ${{ github.workspace }}/apps/ledger-live-desktop/metafile.*
 
       - name: Push status
         id: status
         shell: bash
-        if: always() && !cancelled()
+        if: ${{ !cancelled() }}
         run: echo "${{ matrix.config.name }}=${{ steps.build-app.outcome }}" >> $GITHUB_OUTPUT
 
   report:
     needs: build-desktop-app
     runs-on: ubuntu-latest
-    if: always() && !cancelled() && github.event_name == 'workflow_dispatch'
+    if: ${{ !cancelled() && github.event_name == 'workflow_dispatch' }}
     steps:
       - uses: actions/checkout@v4
         with:
@@ -156,7 +156,7 @@ jobs:
           attempt: ${{ github.run_attempt }}
 
       - uses: ./tools/actions/build-checks
-        if: always() && inputs.prNumber != ''
+        if: ${{ !cancelled() && inputs.prNumber != '' }}
         with:
           token: ${{ steps.generate-token.outputs.token }}
           baseBranch: ${{ inputs.base_ref || 'develop' }}

.github/workflows/build-mobile-external.yml

@@ -104,7 +104,7 @@ jobs:
   report:
     runs-on: ubuntu-latest
     needs: [build-mobile-app-android, build-mobile-app-ios]
-    if: always() && !cancelled() && github.event_name == 'workflow_dispatch'
+    if: ${{ !cancelled() && github.event_name == 'workflow_dispatch' }}
     steps:
       - uses: actions/github-script@v6
         name: get statuses of runs

.github/workflows/build-mobile.yml

@@ -142,7 +142,7 @@ jobs:
   report:
     runs-on: ubuntu-latest
     needs: [build-mobile-app-android, build-mobile-app-ios]
-    if: always() && !cancelled() && github.event_name == 'workflow_dispatch'
+    if: ${{ !cancelled() && github.event_name == 'workflow_dispatch' }}
     steps:
       - name: generate token
         id: generate-token

.github/workflows/commitlint.yml

@@ -46,14 +46,14 @@ jobs:
           pnpm commitlint --from ${{ inputs.from && format('origin/{0}', inputs.from) || 'HEAD^1' }} 2>&1 | tee commitlint.out
       - uses: actions/upload-artifact@v3
         name: upload commitlint output
-        if: always()
+        if: ${{ !cancelled() }}
         with:
           name: commitlint
           path: ${{ github.workspace }}/commitlint.out
   report:
     runs-on: ubuntu-latest
     needs: [lint-commits]
-    if: always() && !cancelled()
+    if: ${{ !cancelled() }}
     steps:
       - name: download commitlint output
         uses: actions/download-artifact@v3

.github/workflows/generate-screenshots.yml

@@ -85,110 +85,6 @@ jobs:
         with:
           os: ubuntu-latest
 
-  generate-screenshots-windows:
-    env:
-      NODE_OPTIONS: "--max-old-space-size=7168"
-      FORCE_COLOR: 3
-      PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1
-    runs-on: [ledger-live-4xlarge-windows-2022]
-    steps:
-      - name: generate token
-        id: generate-token
-        uses: tibdex/github-app-token@v1
-        with:
-          app_id: ${{ secrets.GH_BOT_APP_ID }}
-          private_key: ${{ secrets.GH_BOT_PRIVATE_KEY }}
-      - uses: actions/checkout@v4
-        if: ${{ inputs.ref != null }}
-        with:
-          ref: ${{ inputs.ref }}
-          fetch-depth: 0
-          token: ${{ steps.generate-token.outputs.token }}
-      - uses: actions/checkout@v4
-        if: ${{ !inputs.ref }}
-        with:
-          fetch-depth: 0
-          token: ${{ steps.generate-token.outputs.token }}
-      - name: Checkout PR
-        if: ${{ inputs.number != null && inputs.ref == null }}
-        run: gh pr checkout ${{ inputs.number }}
-        env:
-          GITHUB_TOKEN: ${{ steps.generate-token.outputs.token }}
-      - name: Setup the toolchain
-        uses: ./tools/actions/composites/setup-toolchain
-        id: toolchain
-        with:
-          upgrade_npm: true
-          skip_turbo_cache: "false"
-          accountId: ${{ secrets.AWS_ACCOUNT_ID_PROD }}
-          roleName: ${{ secrets.AWS_CACHE_ROLE_NAME }}
-          region: ${{ secrets.AWS_CACHE_REGION }}
-          turbo-server-token: ${{ secrets.TURBOREPO_SERVER_TOKEN }}
-      - uses: ./tools/actions/composites/setup-test-desktop
-        id: setup-test-desktop
-        with:
-          skip_ruby: true
-          install_playwright: true
-          turborepo-server-port: ${{ steps.toolchain.outputs.port }}
-      - name: Setup git user
-        uses: ./tools/actions/composites/setup-git-user
-      - uses: ./tools/actions/composites/update-snapshots-desktop
-        id: update-snapshots
-        with:
-          os: windows-latest
-
-  generate-screenshots-mac:
-    env:
-      NODE_OPTIONS: "--max-old-space-size=7168"
-      FORCE_COLOR: 3
-      PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1
-    runs-on: [m1, ARM64]
-    steps:
-      - name: generate token
-        id: generate-token
-        uses: tibdex/github-app-token@v1
-        with:
-          app_id: ${{ secrets.GH_BOT_APP_ID }}
-          private_key: ${{ secrets.GH_BOT_PRIVATE_KEY }}
-      - uses: actions/checkout@v4
-        if: ${{ inputs.ref != null }}
-        with:
-          ref: ${{ inputs.ref }}
-          fetch-depth: 0
-          token: ${{ steps.generate-token.outputs.token }}
-      - uses: actions/checkout@v4
-        if: ${{ !inputs.ref }}
-        with:
-          fetch-depth: 0
-          token: ${{ steps.generate-token.outputs.token }}
-      - name: Checkout PR
-        if: ${{ inputs.number != null && inputs.ref == null }}
-        run: gh pr checkout ${{ inputs.number }}
-        env:
-          GITHUB_TOKEN: ${{ steps.generate-token.outputs.token }}
-      - name: Setup the toolchain
-        uses: ./tools/actions/composites/setup-toolchain
-        id: toolchain
-        with:
-          # skip_pnpm_cache: "true"
-          skip_turbo_cache: "false"
-          accountId: ${{ secrets.AWS_ACCOUNT_ID_PROD }}
-          roleName: ${{ secrets.AWS_CACHE_ROLE_NAME }}
-          region: ${{ secrets.AWS_CACHE_REGION }}
-          turbo-server-token: ${{ secrets.TURBOREPO_SERVER_TOKEN }}
-      - uses: ./tools/actions/composites/setup-test-desktop
-        id: setup-test-desktop
-        with:
-          skip_ruby: true
-          install_playwright: true
-          turborepo-server-port: ${{ steps.toolchain.outputs.port }}
-      - name: Setup git user
-        uses: ./tools/actions/composites/setup-git-user
-      - uses: ./tools/actions/composites/update-snapshots-desktop
-        id: update-snapshots
-        with:
-          os: macos-latest
-
   report-start:
     name: Report start
     runs-on: ubuntu-latest
@@ -225,11 +121,9 @@ jobs:
     needs:
       [
         "generate-screenshots-linux",
-        "generate-screenshots-windows",
-        "generate-screenshots-mac",
         "report-start",
       ]
-    if: always()
+    if: ${{ !cancelled() }}
     name: Report end
     runs-on: "ubuntu-latest"
     steps: