Update rust SDK and fix keccak256 declaration #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bboilot-ledger
force-pushed
the
bboilot/update_sdk
branch
from
fc6543e
to
6c5adce
Compare
yhql
previously approved these changes
Mar 28, 2024
bboilot-ledger
force-pushed
the
bboilot/update_sdk
branch
from
6c5adce
to
223e5e5
Compare
|
Hi, as soon as LedgerHQ/ledger-app-workflows#67 is merged (solving LedgerHQ/ledger-app-workflows#66), you can revert commit 3c69297 and update snapshots for Nano S and X and CI should be ✅ |
yogh333
force-pushed
the
bboilot/update_sdk
branch
from
2e8edf4
to
223e5e5
Compare
|
Hello, LedgerHQ/ledger-app-workflows#66 is fixed now, so you should be able to update the PR and get CI ✅ |
bboilot-ledger
force-pushed
the
bboilot/update_sdk
branch
from
b6fccd2
to
015f922
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keccak256 API evolved and now requires struct to be mutable. see LedgerHQ/ledger-device-rust-sdk@0a5b615
Since the reusable workflow force the use of the latest SDK, the pipeline are failing on the boilerplate.
This PR updates the SDK version and add the mut keywords to keccak struct instances.