Fixing race condition between mkdir and event listener registration in pidfiles and logger plugins. #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n pidfiles and logger plugins.
|
I'm seeing this also. The net effect is that the pid files either don't exist or the pids are wrong. Either way, this bug breaks the cli functionality. |
|
I wouldn't be surprised if it were becoming defunct given the latest API. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if workers came online before mkdir callbacks fired, their corresponding worker-started callbacks would never run. (no pidfiles or no log files).
I've made the mkdir call synchronous, which shouldn't be a problem as it's called during startup.