add setOldCenterColor() in setColor() #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there anything wrong with this pull request ? Why is it kept open for 4 months ? Tell me if you find anything wrong, please. Thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I want to thank you for your great work and clean code in the first place. HoloColorPicker is just wonderful.
And I believe I just find a bug .It's about the old and new color in the center. I think once a new color is picked, after a MotionEvent.ACTION_MOVE case is called, both old and new center color should be set to the picked color. With both old and new combined into one solid round, the HoloColorPicker can represent the new picked color in a better way.
In additon, if I want to initialize the initial color of HoloColorPicker with another color, instead of the one hard-coded in HoloColorPicker, the new setColor() will just satisfy me.
Correct me if anything wrong. Look forward to your reply. Thank you for your nice job again.